Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune "null" support #284

Open
pmlopes opened this issue Mar 12, 2021 · 1 comment
Open

Prune "null" support #284

pmlopes opened this issue Mar 12, 2021 · 1 comment
Milestone

Comments

@pmlopes
Copy link
Member

pmlopes commented Mar 12, 2021

Redis doesn't allow null in requests. Currently for compatibility reasons we encode null as the String "null". In order to make the behavior consistent with jedis the official client, we should throw an IllegalArgumentException in that case.

In order to avoid breaking changes, for now we should have a JVM flag to enforce it as strict null:

-Dio.vertx.redis.request.null-as-string=true
  • deprecate all nullArg()
  • if the flag is false during the request encoding if a null is present throw IAE
@pmlopes pmlopes added this to the 4.1.0 milestone Mar 12, 2021
@pmlopes
Copy link
Member Author

pmlopes commented May 20, 2021

Initial step in commit: 05100c0

@vietj vietj modified the milestones: 4.1.0, 4.1.1 Jun 1, 2021
@vietj vietj changed the title Deprecate and remove "null" support Prune "null" support Jun 3, 2021
@vietj vietj modified the milestones: 4.1.1, 4.3.0 Jun 3, 2021
@vietj vietj modified the milestones: 4.3.0, 4.3.1 May 12, 2022
@vietj vietj modified the milestones: 4.3.1, 4.3.2 May 25, 2022
@vietj vietj modified the milestones: 4.3.4, 4.3.5 Oct 1, 2022
@vietj vietj modified the milestones: 4.3.5, 4.4.0 Nov 18, 2022
@vietj vietj modified the milestones: 4.4.0, 4.4.1 Mar 2, 2023
@vietj vietj modified the milestones: 4.4.1, 4.4.2 Mar 31, 2023
@vietj vietj modified the milestones: 4.4.2, 4.4.3 May 12, 2023
@vietj vietj modified the milestones: 4.4.3, 4.4.4-SNAPSHOT, 4.4.4 Jun 7, 2023
@vietj vietj modified the milestones: 4.4.4, 4.4.5 Jun 22, 2023
@vietj vietj modified the milestones: 4.4.5, 4.4.6 Aug 30, 2023
@vietj vietj modified the milestones: 4.4.6, 4.5.0 Sep 12, 2023
@vietj vietj modified the milestones: 4.5.0, 4.5.1 Nov 15, 2023
@vietj vietj modified the milestones: 4.5.1, 4.5.2 Dec 13, 2023
@vietj vietj modified the milestones: 4.5.2, 4.5.3 Jan 30, 2024
@vietj vietj modified the milestones: 4.5.3, 4.5.4 Feb 6, 2024
@vietj vietj modified the milestones: 4.5.4, 4.5.5 Feb 22, 2024
@vietj vietj modified the milestones: 4.5.5, 4.5.6 Mar 14, 2024
@vietj vietj modified the milestones: 4.5.6, 4.5.7, 4.5.8 Mar 21, 2024
@vietj vietj modified the milestones: 4.5.8, 4.5.9 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants