-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MapTiler in Supported Base Maps [Doc] #8777
Comments
I have created this branch https://github.com/bolollo/deck.gl/tree/maptiler, but when I run the tests, some of them fail. They are tests that are not related to the changes I have made. |
Thanks for the initiative, always nice to be able to show wider ecosystem support. Breaking this down:
We are currently doing a lot of work on the deck.gl-community repo which is intended to contain such semi-official integrations, and also be a place to incubate things that could later be promoted to deck.gl core. See for instance: https://visgl.github.io/deck.gl-community/docs/modules/bing-maps |
Hi, @ibgreen, thanks for the clarification and comments. The MapTiler SDKs are based on MapLibre (it has a layer on top with some helpers to make it easier to use MapTiler maps). |
Well, @Pessimistress is the primary maintainer of deck.gl and generally has the final say on what additions the core deck.gl repo is willing to take on. I do suspect that core deck.gl would accept a doc page about how to use "maptiler hosted / maptiler generated basemaps" (with the existing basemap libraries), Given that maptiler is such a well known and widely used base map host, it makes sense to be explicit about it being supported and explain how to use it. For the maptiler SDK examples and integration docs, you could always start developing these in deck.gl-community repo and once they are landed and on the website there it will be easier for everyone to review this, and we could have a discussion about whether to "promote" the code to the deck.gl core repo. |
Commented here My suggestion is that you start by adding the "get-started" examples. Website content has a much higher bar. At this moment I'm not convinced that a library that is a wrapper of (with code that looks identical to) Mapblire must have its own page. |
Cc @HarelM - I know MapTiler is an active participant of the MapLibre community, maybe we can work out a dedicated MapLibre example with MapTiler as the data source? |
I'm not familiar with maptiler's SDK wrapper so I can't help here much. |
@bolollo are you able to clarify what these features are, beyond simpler integration with your platform? |
As I have mentioned, many of the changes are related to the integration with MapTiler platform, I would say that these are the biggest differences:
helpers.addPolyline(map, {
data: "74003ba7-215a-4b7e-8e26-5bbe3aa70b05",
lineColor: "#880000",
outline: true,
}); The layers helpers (modified for general use) would be the only thing that could be integrated into MapLibre in the future. |
In principle we only want one page for each submodule in the developer guide section. The current pages are:
We choose what integration submodules to invest in based on:
We already support MapTiler as the result of supporting MapLibre. I do not believe there's enough value for deck.gl users if we duplicated this content for each MapLibre-derivative library - it belongs in the documentation of respective libraries. We do not have the knowledge and resources required to keep such content up to date. And other than the criteria stated above, we do not promote a certain commercial product over others. |
Link
https://deck.gl/docs/get-started/using-with-map
Description
Add MapTiler in Supported Base Maps and create examples using MapTiler SDK js
Create new pages:
Update:
The text was updated successfully, but these errors were encountered: