Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useEventSource: Return id besides event and data #3974

Closed
4 tasks done
max06 opened this issue May 15, 2024 · 0 comments · Fixed by #3984
Closed
4 tasks done

useEventSource: Return id besides event and data #3974

max06 opened this issue May 15, 2024 · 0 comments · Fixed by #3984
Labels
enhancement New feature or request

Comments

@max06
Copy link

max06 commented May 15, 2024

Clear and concise description of the problem

With the current implementation, it's not possible to react to repeating events/data more than once, for example to ping-events without data. Following the docs, the id is part of the event, and would allow reacting to all messages.

Suggested solution

Add id besides the existing event and data-export.

Alternative

No response

Additional context

More a question... since watch requires ticks between changes to not miss-out on updates, does useEventSource make sure to pass all messages along? Is there any chance we could miss messages if, let's say our source burst sends 100 updates at once?

Validations

@max06 max06 added the enhancement New feature or request label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant