Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collection.batch.rate_limit to take named vectors into account #1000

Open
databyjp opened this issue Apr 8, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@databyjp
Copy link
Contributor

databyjp commented Apr 8, 2024

Currently, the rate_limit number does not take named vectors into account. It would be good to have some way of incorporating these.

Because named vectors allow multiple vectorizers, the API might not be super simple.

We might have to provide some way of providing different rate limits for each vectorizer, through init.Integration for example.

@databyjp databyjp added the enhancement New feature or request label Apr 8, 2024
@sebawita
Copy link

I would prefer to keep rate_limit, as the number of objects added per minute, as calculating rate_limit based on multiple named vectors (with different or same vectorizers) would probably overcomplicate this (now) simple helpful function.

Maybe we could rename the requests_per_minute parameter to objects_per_minute. This way we would make it clearer what is expected to happen.

Mixing vectorizers

Managing batch rate limits across different vectorizers is not a trivial task, and perhaps it could be handled by async vectorization (a different feature we are working on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants