Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experimental] Product Filters Redesign: Hide individual filter blocks from the Block Inserter #47526

Merged
merged 5 commits into from
Jun 3, 2024
Merged

[Experimental] Product Filters Redesign: Hide individual filter blocks from the Block Inserter #47526

merged 5 commits into from
Jun 3, 2024

Conversation

thealexandrelara
Copy link
Contributor

Changes proposed in this Pull Request:

Closes #47525.

How to test the changes in this Pull Request:

  1. Navigate to Single Product template (Appearance > Editor > Templates > Product Catalog template - or any archive template).
  2. Click on "Edit" to open the WordPress editor.
  3. In the editor, you should see a block inserter icon or an option to "Add Block". Click on it.
  4. Search for "filter" in the block inserter.
  5. Make sure you CANNOT see all these inner blocks: Product Filters: Active (Beta), Product Filters: Price (Beta), Product Filters: Stock Status (Beta), Product Filters: Attribute (Beta), Product Filters: Rating (Beta).

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Hide individual filter blocks from the block inserter

@thealexandrelara thealexandrelara added team: Kirigami & Origami block-type: filter blocks Issues related to all of the filter blocks. labels May 15, 2024
@thealexandrelara thealexandrelara self-assigned this May 15, 2024
@thealexandrelara thealexandrelara marked this pull request as draft May 15, 2024 21:30
@woocommercebot woocommercebot requested review from a team and samueljseay and removed request for a team May 15, 2024 21:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

Hi @samueljseay, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 16, 2024
@thealexandrelara thealexandrelara marked this pull request as ready for review May 16, 2024 20:25
@woocommercebot woocommercebot requested a review from a team May 16, 2024 20:25
roykho
roykho approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@roykho roykho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I can confirm indeed the individual filters no longer show in the inserter.

@roykho roykho merged commit b702fb1 into trunk Jun 3, 2024
26 of 27 checks passed
@roykho roykho deleted the feat/47525-hide-individual-filters-from-block-inserter branch June 3, 2024 19:26
@github-actions github-actions bot added this to the 9.1.0 milestone Jun 3, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jun 3, 2024
@samueljseay
Copy link
Contributor

@roykho It's not your fault because it's easy to miss, but you merged with failing e2e tests in Playwright. The blocks e2e tests are not required right now (there is talk of fixing this) so we have to take extra caution.

@samueljseay samueljseay mentioned this pull request Jun 4, 2024
Merged
12 tasks
samueljseay pushed a commit that referenced this pull request Jun 4, 2024
@thealexandrelara @roykho @samueljseay
[Experimental] Product Filters Redesign: Hide individual filter block…
f132a40 
…s from the Block Inserter (#47526)

* Hide individual filter blocks from the inserter

* Add changefile(s) from automation for the following project(s): woocommerce-blocks

* Adjust E2E tests to check for hidden filters

* Fix file conflict

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: roykho <roykho77@gmail.com>
@roykho
Copy link
Member

roykho commented Jun 4, 2024

@samueljseay strange because there was a file conflict that happens to be the test file. I fixed it here and I thought that was the reason.

@samueljseay
Copy link
Contributor

@roykho not a big thing, the merge just went wrong because you accidentally reintroduced the old test in that merge conflict

@samueljseay
Copy link
Contributor

PR for fix: #48122

samueljseay added a commit that referenced this pull request Jun 4, 2024
@samueljseay
Fix an e2e test that was merged incorrectly in #47526 (#48122)
8696a2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roykho roykho roykho approved these changes

@samueljseay samueljseay Awaiting requested review from samueljseay samueljseay was automatically assigned from woocommerce/woo-fse

Assignees

@thealexandrelara thealexandrelara

Labels
block-type: filter blocks Issues related to all of the filter blocks. needs: analysis Indicates if the PR requires a PR testing scrub session. plugin: woocommerce Issues related to the WooCommerce Core plugin. team: Kirigami & Origami
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

Product Filters Redesign: Hide Individual Filters from the Block Inserter
3 participants
@thealexandrelara @samueljseay @roykho