Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failures due to Os { code: 24, kind: Uncategorized, message: "Too many open files" } #11142

Open
1 task done
cqfd opened this issue Apr 29, 2024 · 0 comments
Open
1 task done
Labels
defect [core label] workspace Feedback for workspace management, layout, interactions, etc

Comments

@cqfd
Copy link

cqfd commented Apr 29, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Hi! After following the instructions for building from source I got some test failures when running cargo tests --workspace:

failures:
    tests::following_tests::test_auto_unfollowing
    tests::following_tests::test_following_to_channel_notes_without_a_shared_project
    tests::integration_tests::test_basic_calls
    tests::integration_tests::test_calling_multiple_users_simultaneously
    tests::integration_tests::test_calls_on_multiple_connections
    tests::integration_tests::test_canceling_buffer_opening
    tests::integration_tests::test_client_disconnecting_from_room
    tests::integration_tests::test_collaborating_with_diagnostics
    tests::integration_tests::test_contact_requests
    tests::integration_tests::test_contacts
    tests::integration_tests::test_document_highlights
    tests::integration_tests::test_editing_while_guest_opens_buffer
    tests::integration_tests::test_formatting_buffer
    tests::integration_tests::test_fs_operations
    tests::integration_tests::test_git_branch_name
    tests::integration_tests::test_git_diff_base_change
    tests::integration_tests::test_git_status_sync
    tests::integration_tests::test_join_after_restart
    tests::integration_tests::test_join_call_after_screen_was_shared
    tests::integration_tests::test_joining_channels_and_calling_multiple_users_simultaneously
    tests::integration_tests::test_leaving_project
    tests::integration_tests::test_leaving_worktree_while_opening_buffer
    tests::integration_tests::test_local_settings
    tests::integration_tests::test_lsp_hover
    tests::integration_tests::test_mute_deafen
    tests::integration_tests::test_open_buffer_while_getting_definition_pointing_to_it
    tests::integration_tests::test_prettier_formatting_buffer
    tests::integration_tests::test_preview_tabs
    tests::integration_tests::test_project_reconnect
    tests::integration_tests::test_project_search
    tests::integration_tests::test_project_symbols
    tests::integration_tests::test_propagate_saves_and_fs_changes
    tests::integration_tests::test_references
    tests::integration_tests::test_reloading_buffer_manually
    tests::integration_tests::test_right_click_menu_behind_collab_panel
    tests::integration_tests::test_room_location
    tests::integration_tests::test_room_uniqueness
    tests::integration_tests::test_server_restarts
    tests::integration_tests::test_unshare_project
    tests::notification_tests::test_notifications
    tests::random_channel_buffer_tests::test_random_channel_buffers
    tests::random_project_collaboration_tests::test_random_project_collaboration

test result: FAILED. 119 passed; 42 failed; 0 ignored; 0 measured; 0 filtered out; finished in 21.75s

Running with RUST_BACKTRACE=1 showed a bunch of Os { code: 24, kind: Uncategorized, message: "Too many open files" } errors. In my shell ulimit -n is apparently 256, so I tried doing ulimit -n 1000 and that fixed things. Would it make sense to add a note about this to the build instructions? (Or maybe my open files limit is unexpectedly low?)

Environment

Zed: v0.129.2 (Zed)
OS: macOS 14.4.1
Memory: 36 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@cqfd cqfd added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Apr 29, 2024
@Moshyfawn Moshyfawn added workspace Feedback for workspace management, layout, interactions, etc and removed triage Maintainer needs to classify the issue labels Apr 29, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

3 participants