Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permalinks support enterprise github repository #11160

Open
1 task done
tkolleh opened this issue Apr 29, 2024 · 2 comments
Open
1 task done

Permalinks support enterprise github repository #11160

tkolleh opened this issue Apr 29, 2024 · 2 comments
Labels
collaboration The umbrella label for all collaboration features editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label] git Git integration feedback

Comments

@tkolleh
Copy link

tkolleh commented Apr 29, 2024

Check for existing issues

  • Completed

Describe the feature

Support for generating permalinks for enterprise Github repositories.
To reproduce:

  • Open project linked to an enterprise Github repo
  • Type :copy permalink
  • See the error "failed to parse Git remote URL"

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@tkolleh tkolleh added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Apr 29, 2024
@Moshyfawn Moshyfawn added collaboration The umbrella label for all collaboration features git Git integration feedback editor Feedback for code editing, formatting, editor iterations, etc and removed triage Maintainer needs to classify the issue labels Apr 29, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Apr 30, 2024
@maxdeviant
Copy link
Member

One complication here is that for self-hosted instances of GitHub/GitLab/etc. we can't tell which one is being used based on the URL alone, as the URL could be something like git.bigco.com.

@github-actions github-actions bot mentioned this issue May 4, 2024
Open
@Moshyfawn
Copy link
Contributor

Moshyfawn commented May 8, 2024 •
edited

I can copy a permalink to a line in a private Enterprise repository hosted on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
collaboration The umbrella label for all collaboration features editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label] git Git integration feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maxdeviant @tkolleh @Moshyfawn @JosephTLyons