Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zig extension unable to find & install ZLS from Github Releases. #11162

Open
1 task done
hellopatrick opened this issue Apr 29, 2024 · 1 comment
Open
1 task done

Zig extension unable to find & install ZLS from Github Releases. #11162

hellopatrick opened this issue Apr 29, 2024 · 1 comment
Labels
defect [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc language An umbrella label for all programming languages syntax behaviors zig Zig programming language support

Comments

@hellopatrick
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

The Zig extension fails to install ZLS. It appears to expect the Github artifact to end with tar.gz. However, as of 0.12.0, ZLS release only has tar.xz (Relevant ZLS issue)

Environment

Zed: v0.132.3 (Zed)
OS: macOS 14.4.1
Memory: 18 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Caused by:
    No such file or directory (os error 2)
2024-04-27T18:50:52-07:00 [INFO] starting language server "zls", path: "/Users/pr/Code/essai", id: 4
2024-04-27T18:50:52-07:00 [ERROR] failed to start language server "zls": no asset found matching "zls-aarch64-macos.tar.gz"
2024-04-27T18:50:52-07:00 [ERROR] server stderr: Some("")
2024-04-27T18:50:52-07:00 [INFO] retrying installation of language server "zls" in 1s
2024-04-27T18:50:53-07:00 [INFO] About to spawn test binary
2024-04-27T18:50:53-07:00 [WARN] test binary failed to launch
2024-04-27T18:50:53-07:00 [WARN] test binary check failed
2024-04-27T18:50:53-07:00 [INFO] beginning to reinstall server
2024-04-27T18:50:53-07:00 [INFO] deleting server container
2024-04-27T18:50:53-07:00 [ERROR] crates/language/src/language_registry.rs:850: server container removal
@hellopatrick hellopatrick added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Apr 29, 2024
@Moshyfawn Moshyfawn added language An umbrella label for all programming languages syntax behaviors zig Zig programming language support extension infrastructure Feedback for extensions APIs, creation, management, etc and removed triage Maintainer needs to classify the issue labels Apr 29, 2024
@simonhochrein
Copy link

simonhochrein commented Apr 30, 2024

Tracked this down to these two lines.

zed::Os::Mac | zed::Os::Linux => "tar.gz",

zed::Os::Mac | zed::Os::Linux => zed::DownloadedFileType::GzipTar,

However this looks like an upstream bug.

zigtools/zls#1879 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc language An umbrella label for all programming languages syntax behaviors zig Zig programming language support
Projects
None yet
Development

No branches or pull requests

4 participants