Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlay Hints coloring doesn't accept alpha values defined under "hint:" by themes #11220

Open
1 task done
tecandrew opened this issue Apr 30, 2024 · 0 comments
Open
1 task done
Labels
defect [core label] inlay hints theme Feedback for theme configuration, accessibility, visual issues, etc

Comments

@tecandrew
Copy link

tecandrew commented Apr 30, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

while debugging a theme I found that settings.json > inlay_hints coloring doesn't accept alpha values, or mixes it?, that are defined by a theme using hint: .... this parameter affects the git blame coloring and other stuff, which does accept the opacity alpha values stuff. See photo

(input template)

{
...
    "hint": "#{{ c.red | mod(opacity=0.3) | get(key="hex") }}",
    "hint.border": "#{{ c.red | mod(opacity=0.3) | get(key="hex") }}",
    "hint.background": "#{{ c.mantle.hex }}",
...
}

(output json for themes/theme.json)

{
...
  "hint": "#d20f394d",
  "hint.border": "#d20f394d",
  "hint.background": "#e6e9ef",
...
}

the : void and : Provise<void> are the inlay hints from a javascript file. you can see it's not the same color as the "winston" git blame coloring, but it's a shade of red that I defined for testing

image

Environment

Zed: v0.132.5 (Zed)
OS: macOS 14.4.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@tecandrew tecandrew added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Apr 30, 2024
@JosephTLyons JosephTLyons added theme Feedback for theme configuration, accessibility, visual issues, etc inlay hints and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] inlay hints theme Feedback for theme configuration, accessibility, visual issues, etc
Projects
None yet
Development

No branches or pull requests

2 participants