Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noisy network calls to collab.zed.dev even when disabling chat and collaboration panels #11223

Open
1 task done
tecandrew opened this issue Apr 30, 2024 · 3 comments
Open
1 task done
Labels
defect [core label] network Network connectivity issues, protocols and services support

Comments

@tecandrew
Copy link

tecandrew commented Apr 30, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I monitor my network DNS calls and traffic, and the the last 24 hours collab.zed.dev has been called hundreds of times even when I have my settings to disable chat and collaboration stuff as off. I figured these settings would also disable network calls to collab stuff?

image

  "chat_panel": {
    "button": false
  },
  "collaboration_panel": {
    "button": false
  },

Other Observations

I eventually blocked that domain entirely, and as a result the top right "GitHub" icon shows that I'm not logged in anymore and makes me think that the git blame stuff doesn't work, but it does 😃 so it's a bit confusing

Screenshot 2024-04-30 at 1 06 22 PM

Environment

Zed: v0.132.5 (Zed)
OS: macOS 14.4.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@tecandrew tecandrew added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Apr 30, 2024
@ConradIrwin
Copy link
Collaborator

Do you have telemetry enabled? That will also hit collab.zed.dev with usage data, panics and crashes.

@tecandrew
Copy link
Author

no, I don't have telemetry enabled 😅

  "telemetry": {
    "diagnostics": false,
    "metrics": false
  }

is what I have set in my settings.json

@ConradIrwin
Copy link
Collaborator

Hmm! I wonder if we just spend energy keeping an idle unused connection open for you in case you change your mind...

I've noticed that we see more reconnects on our server than I'd expect, so it seems plausible that we establish a web-socket connection, wait for it to idle timeout, and then re-establish it, over and over again.

Seems worth fixing!

@JosephTLyons JosephTLyons added network Network connectivity issues, protocols and services support and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] network Network connectivity issues, protocols and services support
Projects
None yet
Development

No branches or pull requests

3 participants