Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An error in the Retrieval.py #33

Open
jiajinuiuc opened this issue Jun 13, 2023 · 0 comments
Open

An error in the Retrieval.py #33

jiajinuiuc opened this issue Jun 13, 2023 · 0 comments

Comments

@jiajinuiuc
Copy link

jiajinuiuc commented Jun 13, 2023 •
edited

Dear authors,
Thanks for sharing the code.
I just noticed that in the Retrieval.py, in the evaluation process, the model_without_ddp is not updated with the new model parameters as in the other finetuning tasks. Please let me know if I'm wrong. Thank you!
@jiajinuiuc jiajinuiuc changed the title An error the Retrieval.py An error in the Retrieval.py Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiajinuiuc