Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 will remove findDOMNode #972

Open
2 of 8 tasks
ElliotNB opened this issue May 3, 2024 · 2 comments
Open
2 of 8 tasks

React 19 will remove findDOMNode #972

ElliotNB opened this issue May 3, 2024 · 2 comments

Comments

@ElliotNB
Copy link

ElliotNB commented May 3, 2024

React 19 will be officially released in June/July 2024 and it removes the deprecated ReactDOM.findDOMNode utility. It appears that this will prevent react-quill users from upgrading to React 19.

I recently installed React 18.3 (which was released about a week ago) and it started issuing warnings about this:

Warning: findDOMNode is deprecated and will be removed in the next major release. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node

I didn't see another issue opened regarding the removal of findDOMNode so I thought I'd bring this issue to the attention of the maintainers (@zenoamaro @alexkrolick).

Thank you for your on-going maintenance of this project!

Ticket due diligence

  • I have verified that the issue persists under ReactQuill v2.0.0-beta.2
  • I can't use the beta version for other reasons

ReactQuill version

  • master
  • v2.0.0-beta.2
  • v2.0.0-beta.1
  • 1.3.5
  • 1.3.4 or older
  • Other (fork)
@paleo
Copy link

paleo commented May 10, 2024

Just in case. In the Quill playground, there's an example of using Quill with React: https://quilljs.com/playground/react

@wesrog
Copy link

wesrog commented May 31, 2024

Here's a PR that proposes a fix for this issue: #980. Not sure if the maintainer(s) are actively monitoring, but I have been testing it locally and it works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants