Update About page to display correct Freetube logo based on currently set theme #5126
Conversation
github-actions
bot
added
the
PR: waiting for review
Head branch was pushed to by a user without write access
|
Could you please use relative sizes instead of absolute pixel amounts, as the logo is larger than it was before on smaller screen sizes and on mobile is gigantic and split onto two separate lines. I've provided some before and after screenshots below demonstrating the issue: Desktop before
Desktop with this pull request
Mobile before
Mobile with this pull request
|
absidue
added
PR: changes requested
and removed
PR: waiting for review
|
sure, np. I started with rems locally but saw some px values and decided to just stay consistent to start. I added some css to specifically break the Freetube text to a newline when it gets smaller but I can remove that. The top nav just hides the logo text and shows only the icon below 680px. should I replicate that here? |
We have more space on the About page, so ideally it should like the same as it was before, just in different colors. |
|
okie doke. I will work on making it match what was there size and layout wise. I mostly ask because before, the about page just had a single inline svg that scaled down but this PR adds the two elements that get styled so it could be more flexible if desired. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Update About page to display correct Freetube logo based on currently set theme
Pull Request Type
Related issue
closes #4020
Description
This PR updates the About page view to display the Freetube logo similarly to the top nav. It adds two HTML elements in place of the inline svg. Then we can use CSS to style those elements with the logo variables set by each theme.
Screenshots
before:
after:
Desktop