fix: enhance all kinds xpath queries and clean code #6920
+43
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6898.
The root is the following condition statements miss
else
clause, so that it will cause error whenselectedValues
is a string.insomnia/packages/insomnia/src/ui/components/templating/local-template-tags.ts
Lines 724 to 732 in 1d97689
I found similar code in
queryXPath
util function, so I refactored the code with it, and adjustqueryXPath
to deal with all kinds xpath queries.