Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix interval bug in the pynb #6435

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jzhao62
Copy link

@jzhao62 jzhao62 commented May 19, 2024

Pull Request Template for OpenBB Developers

fixing week interval in the copper-gold ratio demo

@CLAassistant
Copy link

CLAassistant commented May 19, 2024

CLA assistant check
All committers have signed the CLA.

@deeleeramone
Copy link
Contributor

Hi! Thanks for the contribution, we appreciate that. In order to merge to the repo, the branch naming conventions are required. Please rename your branch, as bugfix/fix-demo-bugs, to allow for this.

Thanks!

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform labels May 19, 2024
@piiq
Copy link
Contributor

piiq commented May 21, 2024

@luqmanbello how hard would it be to disable branch naming rules for PRs coming from forks?

@jzhao62 can you please sign the CLA? Use the links from the comment of the CLA bot. It's just 3 clicks. We'll handle the merge after that

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.✅ deeleeramone❌ jzhao62You have signed the CLA already but the status is still pending? Let us recheck it.

@luqmanbello
Copy link
Contributor

@luqmanbello how hard would it be to disable branch naming rules for PRs coming from forks?

@piiq I would look into it.

@deeleeramone deeleeramone requested a review from piiq May 29, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants