-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add user auth #1869
Feat: Add user auth #1869
Conversation
* Add GitHub OAuth. * Add Google OAuth. Signed-off-by: ifuryst <ifuryst@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What problem are we solving by introducing auth? We don't yet have any persistence to store or secure anything, and we aren't doing anything with their data either.
Signed-off-by: ifuryst <ifuryst@gmail.com>
Yeah, I have a similar question about the necessity for user auth at the moment. Currently we're developing OpenDevin as single-user software that runs locally. We definitely plan on having a hosted demo, but there are a number of ways of doing this, and depending on the method that is used there the strategy for doing auth would be different. My suggestion would be to put this on the backburner for now, and figure it out when we have a better idea of what a multi-tenant system would look like. |
Signed-off-by: ifuryst <ifuryst@gmail.com>
Okay, if we all believe it's unnecessary at the moment, I can stop working here for now. |
That might be best for now, but thanks for the contribution! We should circle back once we have a better idea of what this will look like. |
The PR will introduce the Basic Auth for OD:
uid
andsid
to enhance the session management. we only have thesid
for now. so we can manage the sandbox containers likeopendev_sandbox_uid_sid
. I also think we can consider stopping the container rather than removing it, and the user can resume the previous session without re-init, and regular cleaning of the useless containers (but the memory/agent context needs to be stored and then recalled when resumed).