Allow setting of the client interface access modifier based on the model access modifier #4820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows changing the client interface access modifier. This PR is to address #1363.
Changes:
TypeAccessModifier
is used. WhenTypeAccessModifier
is set in theOpenApiToCSharpClientCommand
, it sets the settingsClientInterfaceAccessModifier
to the same value. This is required becauseTypeAccessModifier
is found in the Newtonsoft library and not inCSharpClientGeneratorSettings
.CSharpClientGeneratorSettings
defaultsClientInterfaceAccessModifier
topublic
Client.Interface.liquid
to use the newClientInterfaceAccessModifier
settingThis PR does not address valid combination of setting the generated C# class and model to public, but the interface internal. This would require additional work to expose additional arguments to the command line tool and changes to the UI tools. Someone would need to justify the use case that make this additional combination valid and the effort to implement.
Valid in the table means it is valid C# and will compile. This PR really addresses the last item in the table.