Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Language priority order not respected when changing server setting #32438

Merged
merged 2 commits into from
May 20, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented May 15, 2024

Backport of #32170

…ng (#32170)

Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
@dionisio-bot dionisio-bot bot requested review from a team as code owners May 15, 2024 13:13
@dionisio-bot dionisio-bot bot requested a review from gabriellsh May 15, 2024 13:13
Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 29ce571

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented May 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-6.7.3@f3b4da6). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-6.7.3   #32438   +/-   ##
================================================
  Coverage                 ?   53.15%           
================================================
  Files                    ?     2181           
  Lines                    ?    48820           
  Branches                 ?     9955           
================================================
  Hits                     ?    25952           
  Misses                   ?    20526           
  Partials                 ?     2342           
Flag Coverage Δ
e2e 50.63% <ø> (?)
unit 75.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 57988b8 into release-6.7.3 May 20, 2024
42 of 43 checks passed
@ggazzo ggazzo deleted the backport-6.7.3-32170 branch May 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants