Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send _execute_meta results through the queue #83252

Draft
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

sivel
Copy link
Member

@sivel sivel commented May 14, 2024

SUMMARY

Probably the biggest benefit is not special casing meta task results so that they act more like a regular task in the strategy

ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION

Alternative to #83249

@sivel sivel changed the title end _execute_meta results through the queue Send _execute_meta results through the queue May 14, 2024
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels May 14, 2024
@sivel sivel force-pushed the execute-meta-results-queue branch from fed4af9 to fcab571 Compare May 14, 2024 20:32
@sivel
Copy link
Member Author

sivel commented May 14, 2024

Reproducer...

.
├── ansible.cfg
│   │ [defaults]
│   │ forks = 2
├── hosts
│   │ localhost0
│   │ localhost1
│   │ localhost2
│   │ localhost3
│   │ localhost4
│   │ localhost5
│   │ localhost6
│   │ localhost7
│   │ localhost8
│   │ localhost9
│   │
│   │ [all:vars]
│   │ ansible_connection=local
│   │ ansible_python_interpreter={{ansible_playbook_python}}
├── include_me.yml
│   │ - debug:
│   │     msg: include
│   │
│   │ - meta: noop
└── playbook.yml
    │ - hosts: all
    │   gather_facts: false
    │   strategy: host_pinned
    │   tasks:
    │     - name: start
    │       debug:
    │         msg: start
    │
    │     - include_tasks:
    │         file: include_me.yml
    │
    │     - name: end
    │       debug:
    │         msg: end

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label May 16, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants