Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](agg) fix DCHECK failure of agg when failed to alloc memory #35011

Merged
merged 2 commits into from
May 20, 2024
Merged

[fix](agg) fix DCHECK failure of agg when failed to alloc memory #35011

merged 2 commits into from
May 20, 2024

Conversation

jacktengg
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@jacktengg
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9006/25226)
Line Coverage: 27.37% (74525/272239)
Region Coverage: 26.61% (38526/144773)
Branch Coverage: 23.44% (19661/83872)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5de0c37b039b7576afcc081b0cedc4023affff85_5de0c37b039b7576afcc081b0cedc4023affff85/report/index.html

yiguolei
yiguolei reviewed May 19, 2024
View reviewed changes
be/src/vec/common/string_buffer.hpp
_now_offset = 0;
ColumnString::check_chars_length(_offsets.back() + now_offset, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment here.

@jacktengg
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.71% (9008/25228)
Line Coverage: 27.36% (74497/272266)
Region Coverage: 26.61% (38529/144808)
Branch Coverage: 23.43% (19660/83894)
Coverage Report: http://coverage.selectdb-in.cc/coverage/668365396d4bc4d69c57070c060b27b6db7e6ba7_668365396d4bc4d69c57070c060b27b6db7e6ba7/report/index.html

yiguolei
yiguolei approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit fb89a46 into apache:master May 20, 2024
25 of 28 checks passed
yiguolei pushed a commit that referenced this pull request May 20, 2024
@jacktengg @Doris-Extras
[fix](agg) fix DCHECK failure of agg when failed to alloc memory (#35011
6656508 
)

* [fix](agg) fix DCHECK failure of agg when failed to alloc memory

* add comment
M1saka2003 pushed a commit to M1saka2003/doris that referenced this pull request May 24, 2024
@jacktengg @M1saka2003
[fix](agg) fix DCHECK failure of agg when failed to alloc memory (apa…
14390dc 
…che#35011)

* [fix](agg) fix DCHECK failure of agg when failed to alloc memory

* add comment
dataroaring pushed a commit that referenced this pull request May 26, 2024
@jacktengg @dataroaring
[fix](agg) fix DCHECK failure of agg when failed to alloc memory (#35011
afea977 
)

* [fix](agg) fix DCHECK failure of agg when failed to alloc memory

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacktengg @doris-robot @yiguolei @zhiqiang-hhhh