-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Configurations](multi-catalog) Add enable_parquet_filter_by_min_max
and enable_orc_filter_by_min_max
Session variables.
#35012
[Configurations](multi-catalog) Add enable_parquet_filter_by_min_max
and enable_orc_filter_by_min_max
Session variables.
#35012
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -169,6 +170,7 @@ OrcReader::OrcReader(const TFileScanRangeParams& params, const TFileRangeDesc& r | |||
_file_system(nullptr), | |||
_io_ctx(io_ctx), | |||
_enable_lazy_mat(enable_lazy_mat), | |||
_enable_filter_by_min_max(true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: member initializer for '_enable_filter_by_min_max' is redundant [modernize-use-default-member-init]
_enable_filter_by_min_max(true), | |
, |
e792124
to
99324c6
Compare
run buildall |
99324c6
to
6a3bb5b
Compare
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some tests
ac52f65
to
2d0ac02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -149,6 +149,8 @@ OrcReader::OrcReader(RuntimeProfile* profile, RuntimeState* state, | |||
_ctz(ctz), | |||
_io_ctx(io_ctx), | |||
_enable_lazy_mat(enable_lazy_mat), | |||
_enable_filter_by_min_max( | |||
state == nullptr ? true : state->query_options().enable_orc_filter_by_min_max), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: member initializer for '_dict_cols_has_converted' is redundant [modernize-use-default-member-init]
state == nullptr ? true : state->query_options().enable_orc_filter_by_min_max), | |
, |
@@ -169,6 +171,7 @@ | |||
_file_system(nullptr), | |||
_io_ctx(io_ctx), | |||
_enable_lazy_mat(enable_lazy_mat), | |||
_enable_filter_by_min_max(true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: member initializer for '_dict_cols_has_converted' is redundant [modernize-use-default-member-init]
_enable_filter_by_min_max(true), | |
{ |
…` and `enable_orc_filter_by_min_max` Session variables.
2d0ac02
to
5aa608d
Compare
run buildall |
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…` and `enable_orc_filter_by_min_max` Session variables. (apache#35012)
…` and `enable_orc_filter_by_min_max` Session variables. (apache#35012)
…` and `enable_orc_filter_by_min_max` Session variables. (apache#35012)
…` and `enable_orc_filter_by_min_max` Session variables. (apache#35012)
…` and `enable_orc_filter_by_min_max` Session variables. (apache#35012)
…ionality, the mistake for apache#35012.
…` and `enable_orc_filter_by_min_max` Session variables. (apache#35012)
…` and `enable_orc_filter_by_min_max` Session variables. (apache#35012)
…` and `enable_orc_filter_by_min_max` Session variables. (#35012)
…ionality, the mistake for apache#35012. (apache#35320) fix bug introduced from apache#35012
Proposed changes
[Configurations] (multi-catalog) Add
enable_parquet_filter_by_min_max
andenable_orc_filter_by_min_max
Session variables for workaround.In case that when the column min max statistics in file are incorrect, we can set these variables to skip them
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...