[fix](hudi) catch exception when getting hudi partition #35027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
wuwenchi
approved these changes
May 18, 2024
|
PR approved by anyone and no changes requested. |
morningman
force-pushed
the
hudi_exception_bug
branch
from
f8e9ea9
to
8455973
Compare
|
run buildall |
zddr
approved these changes
May 21, 2024
AshinGau
approved these changes
May 21, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
morningman
added a commit
to morningman/doris
that referenced
this pull request
May 21, 2024
Hudi use a thread pool to get files for each partition. And use a countdown latch to wait all threads finish. But if the thread throw exception, the countdown latch will not be counted down, and thread will be blocked.
morningman
added a commit
that referenced
this pull request
May 22, 2024
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 24, 2024
Hudi use a thread pool to get files for each partition. And use a countdown latch to wait all threads finish. But if the thread throw exception, the countdown latch will not be counted down, and thread will be blocked.
dataroaring
pushed a commit
that referenced
this pull request
May 26, 2024
Hudi use a thread pool to get files for each partition. And use a countdown latch to wait all threads finish. But if the thread throw exception, the countdown latch will not be counted down, and thread will be blocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Hudi use a thread pool to get files for each partition.
And use a countdown latch to wait all threads finish.
But if the thread throw exception, the countdown latch will not be counted down,
and thread will be blocked.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...