Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[featrue](expr) check expr return type and block column type #35032

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[featrue](expr) check expr return type and block column type #35032

wants to merge 2 commits into from
+161 −329

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented May 18, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented May 18, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9014/25246)
Line Coverage: 27.37% (74543/272359)
Region Coverage: 26.62% (38555/144847)
Branch Coverage: 23.45% (19670/83896)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5ded43dbd80cecd31b8afd6f44b194d03087613e_5ded43dbd80cecd31b8afd6f44b194d03087613e/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented May 20, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9014/25246)
Line Coverage: 27.37% (74537/272378)
Region Coverage: 26.61% (38555/144862)
Branch Coverage: 23.43% (19663/83906)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5ded43dbd80cecd31b8afd6f44b194d03087613e_5ded43dbd80cecd31b8afd6f44b194d03087613e/report/index.html

@Mryange Mryange force-pushed the expr-block-column-type-check branch from 5ded43d to 45c3578 Compare May 23, 2024 11:53
@Mryange
Copy link
Contributor Author

Mryange commented May 23, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39992 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 45c357871b4659d1894d978fc78ce8eea60e1d4a, data reload: false

------ Round 1 ----------------------------------
q1	17610	4396	4272	4272
q2	2031	190	197	190
q3	10724	1199	1197	1197
q4	10721	796	726	726
q5	7541	2722	2709	2709
q6	220	133	132	132
q7	974	607	614	607
q8	9419	2131	2121	2121
q9	9143	6642	6608	6608
q10	9747	3708	3679	3679
q11	464	237	235	235
q12	473	225	217	217
q13	17783	2965	2976	2965
q14	275	230	227	227
q15	507	463	466	463
q16	516	378	380	378
q17	960	647	727	647
q18	8141	7566	7407	7407
q19	5660	1544	1523	1523
q20	649	310	321	310
q21	5076	3105	3190	3105
q22	344	282	274	274
Total cold run time: 118978 ms
Total hot run time: 39992 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4328	4192	4198	4192
q2	376	268	272	268
q3	3011	2780	2722	2722
q4	1906	1517	1586	1517
q5	5255	5277	5336	5277
q6	215	124	127	124
q7	2162	1805	1765	1765
q8	3196	3336	3317	3317
q9	8392	8313	8359	8313
q10	3876	3672	3693	3672
q11	592	500	512	500
q12	763	577	581	577
q13	17361	2982	3004	2982
q14	300	266	267	266
q15	516	473	479	473
q16	487	433	433	433
q17	1803	1485	1506	1485
q18	7707	7633	7500	7500
q19	1718	1533	1571	1533
q20	1995	1782	1772	1772
q21	9986	4775	4656	4656
q22	589	486	502	486
Total cold run time: 76534 ms
Total hot run time: 53830 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169337 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 45c357871b4659d1894d978fc78ce8eea60e1d4a, data reload: false

query1	899	376	372	372
query2	6453	2398	2293	2293
query3	6650	200	201	200
query4	19723	17350	17332	17332
query5	4179	415	439	415
query6	271	152	164	152
query7	4581	301	295	295
query8	233	192	211	192
query9	8580	2453	2441	2441
query10	453	274	260	260
query11	10468	10308	10089	10089
query12	141	87	87	87
query13	1627	365	368	365
query14	9185	7633	7096	7096
query15	212	176	173	173
query16	7801	270	255	255
query17	1841	518	513	513
query18	1906	262	259	259
query19	203	155	160	155
query20	94	109	83	83
query21	195	126	127	126
query22	4148	3952	3925	3925
query23	33464	33297	32782	32782
query24	11853	2788	2749	2749
query25	655	379	368	368
query26	1794	154	162	154
query27	2919	318	317	317
query28	7651	2092	2073	2073
query29	1090	599	592	592
query30	307	173	176	173
query31	949	762	739	739
query32	89	55	54	54
query33	764	262	262	262
query34	1004	489	481	481
query35	741	622	612	612
query36	1074	943	918	918
query37	185	71	70	70
query38	2912	2733	2779	2733
query39	856	782	774	774
query40	270	124	134	124
query41	46	44	47	44
query42	101	105	93	93
query43	557	555	549	549
query44	1271	729	739	729
query45	185	158	164	158
query46	1072	706	719	706
query47	1841	1765	1769	1765
query48	358	303	297	297
query49	1172	376	398	376
query50	778	389	371	371
query51	6849	6781	6738	6738
query52	109	87	91	87
query53	350	282	289	282
query54	1010	431	425	425
query55	74	102	70	70
query56	255	241	241	241
query57	1129	1073	1018	1018
query58	233	209	206	206
query59	3369	3076	3098	3076
query60	272	253	250	250
query61	88	91	87	87
query62	652	459	445	445
query63	305	281	281	281
query64	9819	2232	1700	1700
query65	3179	3086	3118	3086
query66	1392	325	315	315
query67	15203	14819	14799	14799
query68	5285	534	533	533
query69	491	281	262	262
query70	1097	1099	1152	1099
query71	446	268	268	268
query72	7201	2714	2580	2580
query73	782	321	332	321
query74	6044	5700	5640	5640
query75	3651	2633	2627	2627
query76	3316	954	914	914
query77	622	265	271	265
query78	10058	9895	9875	9875
query79	1035	525	514	514
query80	836	447	430	430
query81	504	241	240	240
query82	581	96	98	96
query83	188	166	168	166
query84	238	85	86	85
query85	1385	283	263	263
query86	413	298	314	298
query87	3306	3106	3087	3087
query88	3121	2449	2452	2449
query89	474	395	384	384
query90	1932	190	192	190
query91	135	172	95	95
query92	60	55	50	50
query93	1097	517	503	503
query94	1167	183	186	183
query95	404	308	313	308
query96	572	273	268	268
query97	3190	3046	3028	3028
query98	235	219	214	214
query99	1149	867	855	855
Total cold run time: 271104 ms
Total hot run time: 169337 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.9 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 45c357871b4659d1894d978fc78ce8eea60e1d4a, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.24	0.05	0.04
query4	1.67	0.06	0.06
query5	0.48	0.50	0.49
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.53	0.49	0.50
query10	0.55	0.54	0.54
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.58
query14	0.78	0.78	0.78
query15	0.85	0.80	0.80
query16	0.36	0.36	0.37
query17	1.02	1.01	0.99
query18	0.25	0.22	0.27
query19	1.76	1.69	1.66
query20	0.01	0.00	0.01
query21	15.45	0.70	0.66
query22	4.10	7.29	2.31
query23	18.31	1.37	1.31
query24	1.87	0.26	0.22
query25	0.15	0.09	0.08
query26	0.27	0.17	0.17
query27	0.08	0.08	0.08
query28	13.26	1.00	0.98
query29	13.18	3.24	3.24
query30	0.25	0.06	0.05
query31	2.86	0.38	0.38
query32	3.30	0.46	0.47
query33	2.88	2.89	2.86
query34	17.27	4.47	4.45
query35	4.54	4.55	4.51
query36	0.66	0.46	0.46
query37	0.17	0.15	0.15
query38	0.15	0.16	0.15
query39	0.05	0.03	0.04
query40	0.16	0.14	0.15
query41	0.09	0.05	0.05
query42	0.05	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.87 s
Total hot run time: 30.9 s

@Mryange
Copy link
Contributor Author

Mryange commented May 23, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42010 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 45c357871b4659d1894d978fc78ce8eea60e1d4a, data reload: false

------ Round 1 ----------------------------------
q1	17622	4459	4269	4269
q2	2025	199	189	189
q3	10427	1265	1193	1193
q4	10180	817	827	817
q5	7482	2742	2711	2711
q6	224	132	131	131
q7	945	617	605	605
q8	9222	2173	2134	2134
q9	9594	6730	6764	6730
q10	9644	3925	3890	3890
q11	451	245	234	234
q12	489	222	220	220
q13	18212	3277	3197	3197
q14	269	201	225	201
q15	514	459	482	459
q16	501	395	390	390
q17	993	713	779	713
q18	8606	7840	7911	7840
q19	7707	1607	1534	1534
q20	673	320	321	320
q21	5156	3954	3975	3954
q22	354	279	279	279
Total cold run time: 121290 ms
Total hot run time: 42010 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4604	4406	4445	4406
q2	385	272	277	272
q3	3202	2884	2771	2771
q4	1873	1644	1689	1644
q5	5459	5488	5497	5488
q6	219	125	124	124
q7	2239	1835	1792	1792
q8	3247	3434	3399	3399
q9	8686	8668	8644	8644
q10	3910	3835	3835	3835
q11	581	496	505	496
q12	792	602	623	602
q13	16815	3163	3196	3163
q14	299	279	264	264
q15	524	470	477	470
q16	475	420	422	420
q17	1800	1495	1489	1489
q18	7711	7567	7431	7431
q19	1670	1555	1563	1555
q20	2000	1766	1814	1766
q21	11112	4753	4688	4688
q22	576	509	505	505
Total cold run time: 78179 ms
Total hot run time: 55224 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168768 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 45c357871b4659d1894d978fc78ce8eea60e1d4a, data reload: false

query1	908	390	372	372
query2	6437	2519	2334	2334
query3	6640	207	207	207
query4	19849	17395	17202	17202
query5	4138	415	410	410
query6	240	160	152	152
query7	4580	297	289	289
query8	231	180	185	180
query9	8495	2366	2343	2343
query10	446	288	263	263
query11	10672	10022	10096	10022
query12	136	89	92	89
query13	1641	372	370	370
query14	10156	7632	6829	6829
query15	204	175	174	174
query16	7747	274	267	267
query17	1726	543	553	543
query18	1965	275	278	275
query19	202	159	162	159
query20	95	86	87	86
query21	193	128	130	128
query22	4214	4066	4002	4002
query23	33591	33185	32896	32896
query24	6654	2845	2881	2845
query25	532	353	375	353
query26	701	152	158	152
query27	2073	314	314	314
query28	3772	2072	2078	2072
query29	836	602	602	602
query30	233	166	175	166
query31	955	778	733	733
query32	84	54	51	51
query33	496	286	266	266
query34	863	477	487	477
query35	705	623	599	599
query36	1075	941	902	902
query37	109	71	67	67
query38	2877	2781	2752	2752
query39	854	810	793	793
query40	196	120	132	120
query41	47	44	46	44
query42	102	95	93	93
query43	581	570	531	531
query44	1074	714	727	714
query45	184	164	165	164
query46	1061	722	730	722
query47	1830	1746	1779	1746
query48	379	319	291	291
query49	767	367	382	367
query50	769	383	377	377
query51	6869	6787	6617	6617
query52	99	86	88	86
query53	346	287	286	286
query54	536	432	417	417
query55	75	73	76	73
query56	251	234	235	234
query57	1102	1038	1062	1038
query58	237	220	226	220
query59	3419	3233	3292	3233
query60	271	248	269	248
query61	89	85	84	84
query62	550	465	452	452
query63	308	290	285	285
query64	8466	2181	1712	1712
query65	3175	3058	3105	3058
query66	780	324	325	324
query67	15144	14943	14859	14859
query68	4509	527	529	527
query69	460	262	266	262
query70	1169	1129	1121	1121
query71	385	271	264	264
query72	7357	2698	2520	2520
query73	712	321	321	321
query74	6014	5587	5563	5563
query75	3269	2625	2659	2625
query76	2257	913	1020	913
query77	397	262	258	258
query78	10207	9902	9777	9777
query79	2372	521	512	512
query80	926	431	421	421
query81	520	246	243	243
query82	1296	92	92	92
query83	241	171	170	170
query84	249	86	85	85
query85	1188	294	252	252
query86	459	300	268	268
query87	3292	3128	3122	3122
query88	4023	2327	2347	2327
query89	475	383	390	383
query90	2060	191	187	187
query91	121	95	94	94
query92	57	49	51	49
query93	2564	508	493	493
query94	1194	185	180	180
query95	401	301	307	301
query96	597	267	263	263
query97	3192	3032	2986	2986
query98	244	215	215	215
query99	1162	843	843	843
Total cold run time: 259401 ms
Total hot run time: 168768 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 45c357871b4659d1894d978fc78ce8eea60e1d4a, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.06	0.07
query5	0.48	0.50	0.49
query6	1.12	0.72	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.52	0.48	0.49
query10	0.54	0.54	0.53
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.60	0.59	0.60
query14	0.75	0.78	0.78
query15	0.84	0.81	0.81
query16	0.37	0.38	0.38
query17	1.00	1.00	0.94
query18	0.22	0.26	0.24
query19	1.78	1.73	1.69
query20	0.02	0.01	0.01
query21	15.49	0.68	0.65
query22	3.95	7.11	2.22
query23	18.28	1.32	1.20
query24	2.01	0.22	0.21
query25	0.14	0.09	0.08
query26	0.27	0.16	0.17
query27	0.08	0.08	0.08
query28	13.28	1.02	0.99
query29	12.81	3.33	3.28
query30	0.25	0.05	0.05
query31	2.87	0.39	0.38
query32	3.30	0.46	0.47
query33	2.84	2.96	2.89
query34	16.90	4.43	4.40
query35	4.48	4.47	4.48
query36	0.65	0.46	0.48
query37	0.17	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.03
query40	0.17	0.17	0.14
query41	0.09	0.05	0.04
query42	0.05	0.04	0.05
query43	0.03	0.03	0.03
Total cold run time: 108.92 s
Total hot run time: 30.68 s

@Mryange
Copy link
Contributor Author

Mryange commented May 23, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40880 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 00c332420c846010ba4e520768a065385aff3ee9, data reload: false

------ Round 1 ----------------------------------
q1	17615	4273	4221	4221
q2	2004	182	178	178
q3	10471	1134	1203	1134
q4	10193	857	770	770
q5	7476	2705	2708	2705
q6	232	129	131	129
q7	945	605	614	605
q8	9217	2120	2099	2099
q9	10398	6739	6739	6739
q10	9582	3923	3902	3902
q11	445	240	243	240
q12	454	226	227	226
q13	17447	3153	3312	3153
q14	268	218	223	218
q15	506	461	486	461
q16	477	389	390	389
q17	978	684	731	684
q18	8390	7851	7814	7814
q19	5894	1515	1468	1468
q20	641	305	312	305
q21	5177	3171	4050	3171
q22	358	285	269	269
Total cold run time: 119168 ms
Total hot run time: 40880 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4602	4373	4365	4365
q2	378	282	270	270
q3	3165	2892	2973	2892
q4	1872	1597	1628	1597
q5	5445	5508	5473	5473
q6	217	125	126	125
q7	2123	1829	1834	1829
q8	3241	3411	3365	3365
q9	8627	8726	8668	8668
q10	4007	3702	3858	3702
q11	586	503	503	503
q12	830	641	621	621
q13	15944	3160	3123	3123
q14	292	267	266	266
q15	518	476	506	476
q16	485	443	456	443
q17	1819	1547	1508	1508
q18	7722	7757	7686	7686
q19	1666	1586	1564	1564
q20	2042	1777	1767	1767
q21	9419	4735	4621	4621
q22	597	493	488	488
Total cold run time: 75597 ms
Total hot run time: 55352 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172460 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 00c332420c846010ba4e520768a065385aff3ee9, data reload: false

query1	915	393	366	366
query2	6434	2523	2315	2315
query3	6665	210	210	210
query4	19132	17417	17399	17399
query5	4166	433	431	431
query6	257	184	165	165
query7	4581	310	302	302
query8	250	208	189	189
query9	8607	2365	2363	2363
query10	460	308	271	271
query11	10546	10129	9986	9986
query12	137	96	92	92
query13	1642	392	361	361
query14	10214	7754	6876	6876
query15	259	175	172	172
query16	8010	266	262	262
query17	1712	522	537	522
query18	2053	268	273	268
query19	194	153	166	153
query20	94	87	87	87
query21	194	131	129	129
query22	4218	3842	3890	3842
query23	33606	32939	33120	32939
query24	7349	2924	2898	2898
query25	563	362	367	362
query26	702	162	162	162
query27	2177	336	334	334
query28	4905	2025	2059	2025
query29	871	612	610	610
query30	261	175	174	174
query31	942	789	749	749
query32	93	53	55	53
query33	540	272	271	271
query34	883	494	490	490
query35	724	644	605	605
query36	1065	950	909	909
query37	105	75	79	75
query38	2915	2784	2780	2780
query39	882	806	804	804
query40	197	133	157	133
query41	47	45	44	44
query42	102	95	96	95
query43	577	535	569	535
query44	1101	725	735	725
query45	179	170	168	168
query46	1069	722	728	722
query47	1864	1767	1756	1756
query48	380	295	288	288
query49	859	386	390	386
query50	779	397	395	395
query51	6840	6798	6761	6761
query52	102	89	90	89
query53	356	297	290	290
query54	536	428	426	426
query55	77	74	73	73
query56	292	247	258	247
query57	1149	1044	1041	1041
query58	276	210	218	210
query59	3446	3113	3069	3069
query60	277	266	260	260
query61	95	89	87	87
query62	603	467	435	435
query63	311	288	285	285
query64	8480	2303	1742	1742
query65	3147	3086	3096	3086
query66	777	343	332	332
query67	15016	14632	14835	14632
query68	4604	536	546	536
query69	453	278	278	278
query70	1203	1085	1106	1085
query71	378	280	275	275
query72	7702	5608	5546	5546
query73	723	325	325	325
query74	6061	5602	5639	5602
query75	3317	2634	2711	2634
query76	2343	1062	953	953
query77	440	277	277	277
query78	10271	9835	9989	9835
query79	2314	539	544	539
query80	1107	475	478	475
query81	566	250	248	248
query82	804	99	104	99
query83	251	183	180	180
query84	253	91	96	91
query85	1246	318	311	311
query86	455	316	299	299
query87	3327	3138	3153	3138
query88	4002	2351	2351	2351
query89	499	402	391	391
query90	2037	195	201	195
query91	138	109	107	107
query92	66	51	55	51
query93	1566	530	506	506
query94	1324	201	195	195
query95	418	325	322	322
query96	617	274	269	269
query97	3226	2977	2999	2977
query98	254	223	228	223
query99	1140	834	867	834
Total cold run time: 261362 ms
Total hot run time: 172460 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.69 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 00c332420c846010ba4e520768a065385aff3ee9, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.06	0.05
query4	1.66	0.08	0.08
query5	0.47	0.49	0.50
query6	1.11	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.52	0.47	0.48
query10	0.53	0.54	0.54
query11	0.15	0.12	0.11
query12	0.14	0.11	0.12
query13	0.59	0.59	0.60
query14	0.78	0.78	0.78
query15	0.82	0.82	0.82
query16	0.36	0.37	0.37
query17	1.01	1.00	0.98
query18	0.22	0.24	0.24
query19	1.88	1.72	1.65
query20	0.01	0.01	0.00
query21	15.62	0.67	0.65
query22	4.23	6.94	2.03
query23	18.30	1.39	1.29
query24	1.85	0.23	0.25
query25	0.14	0.09	0.09
query26	0.27	0.16	0.16
query27	0.08	0.08	0.09
query28	13.30	1.03	1.01
query29	13.76	3.35	3.24
query30	0.24	0.07	0.05
query31	2.88	0.39	0.38
query32	3.27	0.47	0.48
query33	2.87	2.90	2.90
query34	17.13	4.42	4.42
query35	4.53	4.54	4.70
query36	0.64	0.50	0.46
query37	0.18	0.15	0.15
query38	0.14	0.14	0.14
query39	0.05	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.04
query42	0.05	0.04	0.05
query43	0.04	0.03	0.04
Total cold run time: 110.51 s
Total hot run time: 30.69 s

@Mryange Mryange force-pushed the expr-block-column-type-check branch from 00c3324 to 9dc8398 Compare May 24, 2024 03:39
@Mryange
Copy link
Contributor Author

Mryange commented May 24, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40265 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9dc83985bf25bd9cc42609b164f9f7cc08ecb946, data reload: false

------ Round 1 ----------------------------------
q1	18270	4496	4429	4429
q2	2543	200	209	200
q3	11036	1169	1212	1169
q4	10377	724	787	724
q5	7514	2697	2683	2683
q6	222	135	138	135
q7	973	616	638	616
q8	9315	2078	2091	2078
q9	9106	6448	6505	6448
q10	9001	3725	3752	3725
q11	454	236	236	236
q12	428	214	225	214
q13	18764	2974	3011	2974
q14	257	210	212	210
q15	498	468	458	458
q16	520	382	396	382
q17	974	647	693	647
q18	8231	7576	7646	7576
q19	7411	1543	1476	1476
q20	657	321	307	307
q21	4938	3839	3306	3306
q22	341	274	272	272
Total cold run time: 121830 ms
Total hot run time: 40265 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4339	4212	4199	4199
q2	390	264	275	264
q3	3020	2811	2761	2761
q4	1863	1655	1635	1635
q5	5274	5273	5282	5273
q6	217	124	131	124
q7	2139	1775	1779	1775
q8	3240	3356	3344	3344
q9	8378	8380	8368	8368
q10	3889	3670	3654	3654
q11	581	474	474	474
q12	789	592	608	592
q13	16396	2989	2966	2966
q14	295	272	267	267
q15	508	473	484	473
q16	464	426	408	408
q17	1766	1507	1474	1474
q18	7793	7471	7548	7471
q19	1658	1546	1600	1546
q20	1978	1779	1813	1779
q21	6062	4704	4738	4704
q22	578	477	478	477
Total cold run time: 71617 ms
Total hot run time: 54028 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171601 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9dc83985bf25bd9cc42609b164f9f7cc08ecb946, data reload: false

query1	909	381	372	372
query2	6452	2438	2331	2331
query3	6650	206	210	206
query4	20650	17363	17156	17156
query5	4158	421	417	417
query6	252	160	172	160
query7	4588	305	303	303
query8	243	187	181	181
query9	8591	2362	2336	2336
query10	455	299	255	255
query11	10500	10017	9919	9919
query12	131	94	85	85
query13	1642	365	350	350
query14	10159	7521	7006	7006
query15	222	165	174	165
query16	7819	264	262	262
query17	1835	521	525	521
query18	1928	274	272	272
query19	205	156	165	156
query20	91	87	85	85
query21	195	136	128	128
query22	4179	3865	3958	3865
query23	33572	32846	32908	32846
query24	11801	2901	2892	2892
query25	667	357	354	354
query26	1783	161	160	160
query27	2939	320	322	320
query28	7064	2038	2054	2038
query29	1139	625	580	580
query30	286	172	170	170
query31	966	753	755	753
query32	95	52	52	52
query33	766	277	260	260
query34	1003	484	475	475
query35	743	607	613	607
query36	1097	958	907	907
query37	196	66	72	66
query38	2891	2762	2718	2718
query39	845	789	790	789
query40	281	125	122	122
query41	46	46	46	46
query42	104	96	98	96
query43	584	563	537	537
query44	1259	718	731	718
query45	181	167	157	157
query46	1071	731	713	713
query47	1830	1742	1778	1742
query48	385	287	304	287
query49	1212	376	384	376
query50	763	382	384	382
query51	6907	6807	6771	6771
query52	105	94	89	89
query53	350	290	282	282
query54	1017	438	437	437
query55	75	75	74	74
query56	299	240	240	240
query57	1162	1044	1043	1043
query58	237	208	207	207
query59	3446	3057	3095	3057
query60	273	252	259	252
query61	91	90	90	90
query62	639	482	444	444
query63	306	293	288	288
query64	9814	2327	1841	1841
query65	3204	3100	3113	3100
query66	1385	344	333	333
query67	15250	14793	14836	14793
query68	4597	553	556	553
query69	443	291	282	282
query70	1111	1097	1083	1083
query71	411	280	273	273
query72	7887	5763	5307	5307
query73	729	336	325	325
query74	6034	5637	5588	5588
query75	3345	2658	2628	2628
query76	2637	999	1055	999
query77	424	269	273	269
query78	11049	9796	9644	9644
query79	4902	522	536	522
query80	1728	464	469	464
query81	538	250	245	245
query82	872	99	97	97
query83	345	182	188	182
query84	275	90	91	90
query85	1554	334	263	263
query86	465	303	319	303
query87	3319	3088	3223	3088
query88	5048	2339	2321	2321
query89	500	376	377	376
query90	2024	191	188	188
query91	131	96	98	96
query92	63	49	56	49
query93	5398	511	511	511
query94	1252	184	189	184
query95	399	319	309	309
query96	599	268	300	268
query97	3174	3032	3026	3026
query98	239	221	215	215
query99	1196	857	818	818
Total cold run time: 284671 ms
Total hot run time: 171601 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.59% (9008/25313)
Line Coverage: 27.25% (74452/273179)
Region Coverage: 26.48% (38526/145481)
Branch Coverage: 23.37% (19668/84148)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9dc83985bf25bd9cc42609b164f9f7cc08ecb946_9dc83985bf25bd9cc42609b164f9f7cc08ecb946/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 30.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9dc83985bf25bd9cc42609b164f9f7cc08ecb946, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.04
query3	0.23	0.05	0.05
query4	1.69	0.08	0.08
query5	0.50	0.50	0.50
query6	1.12	0.73	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.55	0.48	0.48
query10	0.54	0.55	0.54
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	0.77	0.77	0.79
query15	0.83	0.81	0.80
query16	0.36	0.37	0.37
query17	1.01	0.98	0.97
query18	0.21	0.24	0.27
query19	1.79	1.67	1.69
query20	0.01	0.00	0.01
query21	15.70	0.66	0.64
query22	3.61	8.11	1.70
query23	18.26	1.42	1.23
query24	1.79	0.28	0.22
query25	0.14	0.09	0.08
query26	0.27	0.16	0.17
query27	0.08	0.07	0.08
query28	13.23	1.02	1.01
query29	12.90	3.35	3.32
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.30	0.47	0.47
query33	2.95	2.90	2.86
query34	17.02	4.46	4.48
query35	4.51	4.53	4.61
query36	0.65	0.46	0.46
query37	0.18	0.15	0.16
query38	0.14	0.15	0.14
query39	0.04	0.04	0.03
query40	0.16	0.14	0.14
query41	0.09	0.05	0.04
query42	0.06	0.04	0.04
query43	0.04	0.04	0.03
Total cold run time: 108.91 s
Total hot run time: 30.34 s

zhangstar333
zhangstar333 reviewed May 24, 2024
View reviewed changes
be/src/vec/exprs/vexpr_context.cpp Outdated
"column is nullable = {} , "
"error type msg = {}",
data.name, expr_data_type->get_name(), column_data_type->get_name(),
column_ptr->is_nullable(), st.msg());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

column_ptr->dump_structure()

@Mryange Mryange force-pushed the expr-block-column-type-check branch from 9dc8398 to cd04324 Compare May 26, 2024 12:51
@doris-robot
Copy link

TPC-H: Total hot run time: 42094 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7cb3c8b54d8f0977c6c6ad79d5ce2747ae77c62d, data reload: false

------ Round 1 ----------------------------------
q1	17612	4574	4306	4306
q2	2044	196	207	196
q3	10436	1297	1175	1175
q4	10203	860	816	816
q5	7504	2770	2699	2699
q6	221	132	138	132
q7	983	643	638	638
q8	9216	2155	2148	2148
q9	9459	6756	6669	6669
q10	9780	3963	3877	3877
q11	445	242	244	242
q12	444	232	232	232
q13	17395	3190	3340	3190
q14	251	216	214	214
q15	517	474	481	474
q16	518	415	393	393
q17	997	708	718	708
q18	8487	7922	7751	7751
q19	7965	1549	1570	1549
q20	631	315	328	315
q21	5179	4273	4079	4079
q22	363	300	291	291
Total cold run time: 120650 ms
Total hot run time: 42094 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4522	4467	4454	4454
q2	386	271	269	269
q3	3165	3027	2755	2755
q4	1890	1607	1660	1607
q5	5553	5520	5524	5520
q6	219	131	131	131
q7	2197	1833	1856	1833
q8	3278	3396	3397	3396
q9	8737	8707	8689	8689
q10	3937	3855	3898	3855
q11	607	506	499	499
q12	819	617	648	617
q13	16293	3113	3209	3113
q14	303	282	283	282
q15	526	490	482	482
q16	489	423	417	417
q17	1785	1488	1495	1488
q18	7966	7547	7459	7459
q19	1672	1544	1620	1544
q20	1989	1776	1806	1776
q21	8044	4808	4781	4781
q22	581	497	475	475
Total cold run time: 74958 ms
Total hot run time: 55442 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169796 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7cb3c8b54d8f0977c6c6ad79d5ce2747ae77c62d, data reload: false

query1	927	374	370	370
query2	6433	2326	2299	2299
query3	6649	207	209	207
query4	19583	17483	17541	17483
query5	4165	431	420	420
query6	249	158	158	158
query7	4593	295	289	289
query8	239	179	177	177
query9	8634	2365	2357	2357
query10	480	285	260	260
query11	10625	10167	10368	10167
query12	140	93	89	89
query13	1634	398	365	365
query14	9940	7782	7344	7344
query15	218	174	168	168
query16	7734	257	260	257
query17	1710	523	523	523
query18	1935	271	270	270
query19	199	148	149	148
query20	88	91	82	82
query21	191	125	137	125
query22	4248	4096	3939	3939
query23	34047	33157	32905	32905
query24	6764	2913	2853	2853
query25	465	348	353	348
query26	706	157	155	155
query27	1921	322	322	322
query28	3897	2080	2073	2073
query29	846	606	602	602
query30	221	152	153	152
query31	934	768	741	741
query32	62	55	56	55
query33	503	269	256	256
query34	847	477	491	477
query35	717	586	594	586
query36	1054	912	875	875
query37	105	65	68	65
query38	2894	2811	2747	2747
query39	854	792	777	777
query40	198	129	127	127
query41	51	46	45	45
query42	106	99	102	99
query43	572	551	568	551
query44	1115	742	755	742
query45	179	171	159	159
query46	1054	724	724	724
query47	1856	1797	1775	1775
query48	381	294	293	293
query49	763	382	389	382
query50	763	383	397	383
query51	6830	6705	6620	6620
query52	97	92	90	90
query53	355	284	285	284
query54	544	445	433	433
query55	73	71	77	71
query56	258	240	256	240
query57	1104	1028	1017	1017
query58	226	218	208	208
query59	3214	2986	3099	2986
query60	263	276	255	255
query61	87	85	84	84
query62	526	446	466	446
query63	320	280	288	280
query64	2530	1764	1783	1764
query65	3159	3104	3129	3104
query66	783	330	331	330
query67	15150	14867	14744	14744
query68	4584	539	546	539
query69	437	262	263	262
query70	1177	1097	1099	1097
query71	381	270	266	266
query72	7234	5437	2695	2695
query73	719	324	325	324
query74	5962	5592	5559	5559
query75	3359	2624	2631	2624
query76	2206	990	987	987
query77	423	320	261	261
query78	10154	9950	9884	9884
query79	1158	522	520	520
query80	1062	435	431	431
query81	494	224	221	221
query82	1262	93	89	89
query83	255	168	164	164
query84	254	85	92	85
query85	921	263	266	263
query86	393	300	295	295
query87	3327	3144	3073	3073
query88	3178	2447	2439	2439
query89	471	382	372	372
query90	1980	187	184	184
query91	121	148	95	95
query92	64	47	47	47
query93	992	521	505	505
query94	1050	183	182	182
query95	407	305	299	299
query96	574	271	267	267
query97	3179	3036	3000	3000
query98	242	225	209	209
query99	1172	854	836	836
Total cold run time: 249200 ms
Total hot run time: 169796 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.24 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7cb3c8b54d8f0977c6c6ad79d5ce2747ae77c62d, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.05
query3	0.23	0.06	0.05
query4	1.68	0.06	0.07
query5	0.51	0.48	0.49
query6	1.12	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.50
query10	0.54	0.55	0.54
query11	0.16	0.11	0.12
query12	0.16	0.12	0.12
query13	0.59	0.59	0.60
query14	0.78	0.78	0.78
query15	0.84	0.82	0.80
query16	0.37	0.37	0.37
query17	1.02	0.97	1.03
query18	0.21	0.25	0.22
query19	1.83	1.69	1.67
query20	0.01	0.01	0.01
query21	15.46	0.72	0.67
query22	5.12	6.82	1.70
query23	18.30	1.39	1.26
query24	2.02	0.23	0.21
query25	0.14	0.08	0.07
query26	0.27	0.16	0.18
query27	0.08	0.08	0.08
query28	13.24	1.01	0.99
query29	13.01	3.32	3.27
query30	0.24	0.06	0.05
query31	2.86	0.39	0.37
query32	3.30	0.47	0.46
query33	2.84	2.96	2.94
query34	17.05	4.36	4.45
query35	4.48	4.52	4.56
query36	0.68	0.46	0.48
query37	0.17	0.15	0.16
query38	0.15	0.14	0.15
query39	0.05	0.03	0.04
query40	0.16	0.14	0.15
query41	0.09	0.04	0.06
query42	0.05	0.04	0.04
query43	0.04	0.04	0.03
Total cold run time: 110.58 s
Total hot run time: 30.24 s

@Mryange Mryange force-pushed the expr-block-column-type-check branch from 7cb3c8b to 895c383 Compare May 29, 2024 09:55
@Mryange
Copy link
Contributor Author

Mryange commented May 29, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42496 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 895c3834141fa7f582e554d20ad48acd20a22a85, data reload: false

------ Round 1 ----------------------------------
q1	17631	4522	4366	4366
q2	2038	199	202	199
q3	10507	1299	1185	1185
q4	10199	829	812	812
q5	7472	2799	2746	2746
q6	228	136	139	136
q7	975	620	629	620
q8	9237	2194	2145	2145
q9	9165	6702	6749	6702
q10	9506	3921	3924	3921
q11	471	253	256	253
q12	451	227	236	227
q13	17239	3301	3215	3215
q14	275	217	248	217
q15	547	492	471	471
q16	521	410	408	408
q17	1043	678	644	644
q18	8448	7930	7912	7912
q19	6080	1685	1638	1638
q20	657	311	330	311
q21	5143	4098	4037	4037
q22	394	347	331	331
Total cold run time: 118227 ms
Total hot run time: 42496 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4559	4408	4475	4408
q2	373	293	273	273
q3	3179	2945	2913	2913
q4	2052	1636	1580	1580
q5	5398	5539	5644	5539
q6	219	125	128	125
q7	2236	1798	1772	1772
q8	3233	3431	3412	3412
q9	8653	8735	8760	8735
q10	4105	3767	3760	3760
q11	599	547	504	504
q12	791	654	671	654
q13	16941	3107	3178	3107
q14	319	285	262	262
q15	541	484	497	484
q16	517	452	440	440
q17	1817	1525	1516	1516
q18	7682	7472	7398	7398
q19	1713	1640	1599	1599
q20	1973	1797	1772	1772
q21	6547	4754	4680	4680
q22	603	523	523	523
Total cold run time: 74050 ms
Total hot run time: 55456 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.82% (9113/25438)
Line Coverage: 27.31% (74829/274047)
Region Coverage: 26.55% (38741/145935)
Branch Coverage: 23.42% (19731/84256)
Coverage Report: http://coverage.selectdb-in.cc/coverage/895c3834141fa7f582e554d20ad48acd20a22a85_895c3834141fa7f582e554d20ad48acd20a22a85/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 171946 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 895c3834141fa7f582e554d20ad48acd20a22a85, data reload: false

query1	939	391	382	382
query2	6461	2583	2396	2396
query3	6632	213	215	213
query4	19893	17290	17230	17230
query5	4204	430	430	430
query6	262	189	164	164
query7	4584	295	292	292
query8	305	299	284	284
query9	8479	2415	2388	2388
query10	457	283	263	263
query11	10528	10129	10045	10045
query12	144	97	87	87
query13	1637	376	363	363
query14	10132	6882	7570	6882
query15	243	189	195	189
query16	7810	266	261	261
query17	1780	524	506	506
query18	1977	283	272	272
query19	195	151	149	149
query20	95	83	83	83
query21	198	130	130	130
query22	4461	4086	4049	4049
query23	33670	32914	33350	32914
query24	11771	2892	2889	2889
query25	633	355	359	355
query26	1704	164	155	155
query27	3005	320	319	319
query28	7575	2082	2078	2078
query29	1042	612	599	599
query30	237	148	159	148
query31	967	748	745	745
query32	90	53	57	53
query33	792	272	263	263
query34	999	472	477	472
query35	738	621	597	597
query36	1079	911	914	911
query37	263	68	67	67
query38	2896	2802	2748	2748
query39	838	818	797	797
query40	245	125	126	125
query41	53	50	51	50
query42	105	102	97	97
query43	620	574	564	564
query44	1243	729	748	729
query45	180	171	168	168
query46	1077	704	700	700
query47	1853	1769	1749	1749
query48	370	305	301	301
query49	975	371	385	371
query50	778	387	428	387
query51	6860	6762	6810	6762
query52	102	92	95	92
query53	385	295	287	287
query54	863	431	417	417
query55	72	72	71	71
query56	264	239	241	239
query57	1124	1045	1066	1045
query58	252	210	208	208
query59	3412	3075	2985	2985
query60	273	262	262	262
query61	92	87	88	87
query62	627	453	440	440
query63	316	298	284	284
query64	9653	2251	1727	1727
query65	3254	3159	3106	3106
query66	1321	340	329	329
query67	15076	14883	14931	14883
query68	4464	553	542	542
query69	424	263	275	263
query70	1186	1091	1082	1082
query71	417	281	269	269
query72	7565	5435	5280	5280
query73	717	319	320	319
query74	6040	5595	5579	5579
query75	3421	2599	2618	2599
query76	2683	1026	932	932
query77	419	270	271	270
query78	10201	9744	9661	9661
query79	2643	510	519	510
query80	1032	432	427	427
query81	550	223	221	221
query82	793	92	94	92
query83	252	172	170	170
query84	247	85	84	84
query85	1344	268	264	264
query86	452	285	296	285
query87	3303	3151	3142	3142
query88	3973	2338	2332	2332
query89	473	460	366	366
query90	2064	185	181	181
query91	123	98	97	97
query92	65	50	52	50
query93	1788	523	504	504
query94	1305	178	178	178
query95	390	299	313	299
query96	592	265	257	257
query97	3161	3007	3011	3007
query98	247	221	205	205
query99	1125	846	857	846
Total cold run time: 274619 ms
Total hot run time: 171946 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.23 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 895c3834141fa7f582e554d20ad48acd20a22a85, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.50	0.50	0.50
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.54	0.48	0.48
query10	0.54	0.55	0.53
query11	0.15	0.12	0.11
query12	0.14	0.12	0.11
query13	0.59	0.59	0.59
query14	0.78	0.79	0.77
query15	0.84	0.81	0.80
query16	0.36	0.36	0.35
query17	0.97	1.02	1.03
query18	0.21	0.24	0.26
query19	1.89	1.74	1.73
query20	0.01	0.02	0.01
query21	15.51	0.69	0.67
query22	4.38	7.17	1.62
query23	18.29	1.32	1.26
query24	1.27	0.42	0.24
query25	0.14	0.09	0.07
query26	0.26	0.16	0.17
query27	0.08	0.09	0.07
query28	13.37	1.00	0.99
query29	12.93	3.31	3.24
query30	0.25	0.06	0.05
query31	2.87	0.37	0.39
query32	3.30	0.46	0.45
query33	2.84	2.91	2.86
query34	17.00	4.41	4.41
query35	4.50	4.51	4.50
query36	0.70	0.48	0.47
query37	0.17	0.16	0.15
query38	0.15	0.15	0.15
query39	0.04	0.04	0.04
query40	0.16	0.14	0.13
query41	0.09	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.16 s
Total hot run time: 30.23 s

@Mryange Mryange force-pushed the expr-block-column-type-check branch from 895c383 to c153f6d Compare May 29, 2024 13:03
@Mryange
Copy link
Contributor Author

Mryange commented May 29, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41515 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c153f6dbd476e6093b9058ff387f295e719a9076, data reload: false

------ Round 1 ----------------------------------
q1	17608	4446	4319	4319
q2	2027	198	201	198
q3	10449	1215	1266	1215
q4	10200	794	742	742
q5	7477	2831	2795	2795
q6	234	137	131	131
q7	972	643	631	631
q8	9220	2168	2149	2149
q9	9161	6780	6781	6780
q10	9709	3898	3850	3850
q11	449	239	238	238
q12	580	255	247	247
q13	17357	3246	3252	3246
q14	261	216	209	209
q15	510	471	475	471
q16	500	413	411	411
q17	1005	758	654	654
q18	8469	7772	7769	7769
q19	7436	1681	1562	1562
q20	649	320	314	314
q21	5533	3906	3262	3262
q22	381	328	322	322
Total cold run time: 120187 ms
Total hot run time: 41515 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4566	4463	4495	4463
q2	386	273	278	273
q3	3178	2999	3001	2999
q4	1945	1558	1563	1558
q5	5400	5493	5571	5493
q6	214	121	125	121
q7	2170	1805	1755	1755
q8	3275	3439	3387	3387
q9	8594	8673	8712	8673
q10	4114	3850	3788	3788
q11	606	488	497	488
q12	796	619	639	619
q13	16956	3159	3174	3159
q14	313	276	279	276
q15	531	498	474	474
q16	490	435	445	435
q17	1824	1532	1513	1513
q18	7708	7637	7431	7431
q19	1707	1637	1635	1635
q20	2005	1793	1798	1793
q21	9112	4662	4784	4662
q22	579	515	512	512
Total cold run time: 76469 ms
Total hot run time: 55507 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 170987 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c153f6dbd476e6093b9058ff387f295e719a9076, data reload: false

query1	912	383	369	369
query2	6966	2431	2440	2431
query3	6647	223	219	219
query4	19193	17529	17301	17301
query5	4143	418	426	418
query6	257	158	172	158
query7	4588	294	294	294
query8	323	286	298	286
query9	8451	2396	2370	2370
query10	450	282	260	260
query11	10422	10180	10162	10162
query12	146	98	93	93
query13	1658	379	354	354
query14	9398	7373	7415	7373
query15	226	195	188	188
query16	7777	261	259	259
query17	1739	520	521	520
query18	1962	272	268	268
query19	208	153	159	153
query20	90	84	83	83
query21	189	128	124	124
query22	4190	4008	3918	3918
query23	33595	33019	33086	33019
query24	10956	2871	2831	2831
query25	606	349	353	349
query26	1142	157	157	157
query27	2281	318	324	318
query28	6998	2057	2047	2047
query29	862	620	619	619
query30	244	149	149	149
query31	978	758	766	758
query32	95	54	54	54
query33	757	261	270	261
query34	961	479	489	479
query35	724	609	586	586
query36	1054	924	923	923
query37	102	73	65	65
query38	2918	2808	2820	2808
query39	856	773	792	773
query40	200	125	125	125
query41	52	51	52	51
query42	106	94	97	94
query43	598	575	532	532
query44	1229	738	745	738
query45	190	172	171	171
query46	1071	720	726	720
query47	1843	1774	1772	1772
query48	369	302	291	291
query49	870	382	388	382
query50	772	383	398	383
query51	6934	6762	6828	6762
query52	107	92	88	88
query53	352	288	296	288
query54	871	431	431	431
query55	73	74	74	74
query56	263	240	255	240
query57	1117	1048	1086	1048
query58	234	251	260	251
query59	3480	3159	3283	3159
query60	271	258	261	258
query61	88	85	89	85
query62	609	440	449	440
query63	316	289	297	289
query64	8655	2247	1713	1713
query65	3204	3117	3162	3117
query66	901	346	343	343
query67	15251	14919	14774	14774
query68	4541	574	529	529
query69	453	270	273	270
query70	1158	1072	1040	1040
query71	412	271	281	271
query72	7733	5364	2875	2875
query73	715	328	323	323
query74	6070	5746	5665	5665
query75	3398	2629	2630	2629
query76	2620	1027	1047	1027
query77	565	276	276	276
query78	10441	9850	10130	9850
query79	2360	522	516	516
query80	1948	474	470	470
query81	530	230	222	222
query82	722	100	101	100
query83	319	187	188	187
query84	270	91	92	91
query85	1710	326	317	317
query86	477	321	334	321
query87	3307	3129	3079	3079
query88	4124	2356	2356	2356
query89	479	399	402	399
query90	2011	197	199	197
query91	141	110	108	108
query92	63	57	54	54
query93	2491	508	496	496
query94	1235	195	201	195
query95	416	331	331	331
query96	599	280	268	268
query97	3244	3038	3039	3038
query98	240	221	229	221
query99	1261	854	850	850
Total cold run time: 271143 ms
Total hot run time: 170987 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c153f6dbd476e6093b9058ff387f295e719a9076, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.07
query5	0.54	0.49	0.50
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.03	0.04
query9	0.54	0.49	0.50
query10	0.54	0.55	0.55
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.59	0.58	0.60
query14	0.79	0.77	0.78
query15	0.83	0.82	0.80
query16	0.35	0.37	0.38
query17	1.02	0.99	0.96
query18	0.22	0.23	0.27
query19	1.78	1.68	1.65
query20	0.01	0.01	0.01
query21	15.51	0.67	0.65
query22	3.85	8.09	2.00
query23	18.27	1.32	1.30
query24	2.04	0.22	0.22
query25	0.13	0.11	0.08
query26	0.26	0.16	0.17
query27	0.07	0.07	0.08
query28	13.24	1.01	0.99
query29	13.62	3.29	3.19
query30	0.24	0.05	0.06
query31	2.87	0.38	0.38
query32	3.30	0.47	0.47
query33	2.90	2.92	2.92
query34	17.14	4.41	4.45
query35	4.55	4.48	4.63
query36	0.68	0.48	0.46
query37	0.18	0.16	0.16
query38	0.16	0.15	0.16
query39	0.04	0.04	0.03
query40	0.16	0.14	0.14
query41	0.09	0.05	0.05
query42	0.05	0.06	0.05
query43	0.04	0.03	0.04
Total cold run time: 110.13 s
Total hot run time: 30.53 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.93% (9140/25439)
Line Coverage: 27.38% (75035/274031)
Region Coverage: 26.60% (38841/146009)
Branch Coverage: 23.46% (19784/84320)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c153f6dbd476e6093b9058ff387f295e719a9076_c153f6dbd476e6093b9058ff387f295e719a9076/report/index.html

@Mryange Mryange force-pushed the expr-block-column-type-check branch from c153f6d to 4d20c93 Compare May 31, 2024 13:47
@Mryange Mryange force-pushed the expr-block-column-type-check branch from 4d20c93 to 1d29209 Compare May 31, 2024 13:50
@Mryange
Copy link
Contributor Author

Mryange commented May 31, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Mryange
Copy link
Contributor Author

Mryange commented Jun 1, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41874 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 54da2b0afe005a9d85f735375bab2a911d6bda9a, data reload: false

------ Round 1 ----------------------------------
q1	17662	4646	4306	4306
q2	2032	197	201	197
q3	10513	1225	1116	1116
q4	10208	863	846	846
q5	7481	2770	2756	2756
q6	229	136	139	136
q7	970	633	642	633
q8	9266	2201	2151	2151
q9	9095	6734	6799	6734
q10	9206	3980	3970	3970
q11	455	251	240	240
q12	434	243	230	230
q13	17388	3200	3264	3200
q14	276	212	220	212
q15	514	477	478	477
q16	497	399	396	396
q17	1018	671	658	658
q18	8493	7815	7737	7737
q19	3678	1243	1490	1243
q20	660	336	315	315
q21	5210	3989	3997	3989
q22	406	334	332	332
Total cold run time: 115691 ms
Total hot run time: 41874 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4650	4478	4434	4434
q2	385	279	274	274
q3	3160	2949	3007	2949
q4	1957	1613	1644	1613
q5	5439	5552	5472	5472
q6	230	125	129	125
q7	2185	1832	1767	1767
q8	3254	3409	3438	3409
q9	8695	8753	8722	8722
q10	4162	3898	3852	3852
q11	589	481	482	481
q12	809	595	596	595
q13	16039	3070	3155	3070
q14	307	268	265	265
q15	524	483	482	482
q16	479	438	450	438
q17	1827	1500	1528	1500
q18	8079	7935	7610	7610
q19	1769	1542	1614	1542
q20	3022	1789	1790	1789
q21	4914	4793	4743	4743
q22	586	521	527	521
Total cold run time: 73061 ms
Total hot run time: 55653 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173524 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 54da2b0afe005a9d85f735375bab2a911d6bda9a, data reload: false

query1	947	382	371	371
query2	6463	2479	2401	2401
query3	6650	204	207	204
query4	19874	17422	17464	17422
query5	4124	453	455	453
query6	247	161	159	159
query7	4581	297	295	295
query8	336	284	286	284
query9	8558	2398	2381	2381
query10	448	304	290	290
query11	10584	9941	10178	9941
query12	133	101	89	89
query13	1638	382	379	379
query14	9842	7704	7437	7437
query15	236	193	189	189
query16	7785	268	265	265
query17	1744	521	504	504
query18	1927	269	271	269
query19	212	167	163	163
query20	95	86	88	86
query21	204	127	132	127
query22	4181	3912	4022	3912
query23	33622	33165	33118	33118
query24	11652	2839	2836	2836
query25	649	355	376	355
query26	1763	155	159	155
query27	2942	309	317	309
query28	7328	2057	2055	2055
query29	1104	603	599	599
query30	278	148	150	148
query31	979	760	750	750
query32	95	55	56	55
query33	739	273	282	273
query34	939	482	465	465
query35	792	641	627	627
query36	1068	892	901	892
query37	214	70	71	70
query38	2963	2770	2783	2770
query39	866	806	798	798
query40	277	126	127	126
query41	53	52	52	52
query42	124	99	97	97
query43	590	571	569	569
query44	1300	730	749	730
query45	208	162	167	162
query46	1095	742	720	720
query47	1817	1779	1789	1779
query48	390	306	297	297
query49	1097	394	416	394
query50	796	378	392	378
query51	6917	6812	6828	6812
query52	104	91	91	91
query53	364	293	295	293
query54	896	466	458	458
query55	78	72	72	72
query56	306	254	271	254
query57	1129	1021	1034	1021
query58	267	244	254	244
query59	3436	3269	3120	3120
query60	291	282	264	264
query61	90	89	84	84
query62	624	472	444	444
query63	314	295	294	294
query64	9885	2279	1736	1736
query65	3292	3087	3111	3087
query66	1326	328	320	320
query67	15170	14660	14724	14660
query68	4465	555	553	553
query69	466	335	331	331
query70	1136	1149	1057	1057
query71	411	293	282	282
query72	7175	5623	5476	5476
query73	752	326	321	321
query74	6118	5670	5656	5656
query75	3369	2701	2669	2669
query76	2767	872	886	872
query77	482	313	298	298
query78	10264	9880	9886	9880
query79	1291	522	522	522
query80	1890	473	460	460
query81	604	221	217	217
query82	1085	109	103	103
query83	301	173	171	171
query84	263	91	83	83
query85	1276	274	264	264
query86	398	322	299	299
query87	3251	3141	3112	3112
query88	2911	2345	2344	2344
query89	477	395	394	394
query90	1817	197	197	197
query91	141	110	109	109
query92	67	52	53	52
query93	1068	529	519	519
query94	1234	212	195	195
query95	416	323	322	322
query96	580	275	275	275
query97	3204	3031	3006	3006
query98	268	225	217	217
query99	1102	819	814	814
Total cold run time: 272087 ms
Total hot run time: 173524 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.20% (9225/25485)
Line Coverage: 27.57% (75625/274271)
Region Coverage: 26.79% (39143/146121)
Branch Coverage: 23.57% (19878/84348)
Coverage Report: http://coverage.selectdb-in.cc/coverage/54da2b0afe005a9d85f735375bab2a911d6bda9a_54da2b0afe005a9d85f735375bab2a911d6bda9a/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 30.37 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 54da2b0afe005a9d85f735375bab2a911d6bda9a, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.06	0.05
query4	1.67	0.11	0.10
query5	0.49	0.50	0.50
query6	1.13	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.53	0.49	0.48
query10	0.54	0.53	0.53
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.61
query14	0.79	0.78	0.80
query15	0.84	0.81	0.80
query16	0.37	0.35	0.36
query17	0.98	0.94	0.94
query18	0.21	0.24	0.26
query19	1.82	1.70	1.72
query20	0.01	0.02	0.01
query21	15.45	0.71	0.67
query22	4.94	7.14	1.82
query23	18.32	1.40	1.20
query24	1.92	0.25	0.21
query25	0.14	0.08	0.08
query26	0.26	0.17	0.16
query27	0.08	0.07	0.08
query28	13.29	1.01	1.00
query29	13.31	3.31	3.28
query30	0.24	0.05	0.06
query31	2.87	0.39	0.38
query32	3.29	0.48	0.47
query33	2.89	2.92	2.94
query34	17.21	4.45	4.43
query35	4.51	4.45	4.69
query36	0.64	0.46	0.46
query37	0.17	0.16	0.15
query38	0.15	0.14	0.14
query39	0.04	0.04	0.03
query40	0.17	0.14	0.14
query41	0.09	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.03
Total cold run time: 110.76 s
Total hot run time: 30.37 s

@Mryange Mryange marked this pull request as ready for review June 2, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangstar333 zhangstar333 zhangstar333 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mryange @doris-robot @zhangstar333