[HUDI-7763] Fix that multiple jmx reporter can exist if metadata enables #11226
+81
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
May 16, 2024
| jmxReporterServer = createJmxReport(host, port); | ||
| LOG.info("Started JMX server on port " + port + "."); | ||
| break; | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Should we catch specific exception type here?
There was a problem hiding this comment.
Should we catch specific exception type here?
c7b4028
Callee function catches all exceptions, then rethrow to HoodieException.
Thus, check causes and log messages in detail.
Thanks for comment
- catch exception that caused by already in use port
danny0405
reviewed
May 16, 2024
| LOG.info("Skip for initializing jmx port " + port + " because of already in use"); | ||
| } else { | ||
| LOG.info("Failed to initialize jmx port " + port + ". " + e.getMessage()); | ||
| } |
There was a problem hiding this comment.
LOG.info("Failed to initialize jmx port " + port + ". "， e); ?
There was a problem hiding this comment.
emit log if all unknown error occur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
metrics - JmxReporter
Risk level (write none, low medium or high below)
low
Documentation Update
none
Contributor's checklist