Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][Jdbc] Fix oracle savemode create table #6651

Merged
merged 1 commit into from May 14, 2024
Merged

[Hotfix][Jdbc] Fix oracle savemode create table #6651

merged 1 commit into from May 14, 2024

Conversation

hailin0
Copy link
Contributor

@hailin0 hailin0 commented Apr 7, 2024

Purpose of this pull request

[Jdbc] Fix oracle savemode create table

Does this PR introduce any user-facing change?

No

How was this patch tested?

Check list

@hailin0
Copy link
Contributor Author

hailin0 commented Apr 7, 2024

image

@hailin0 hailin0 marked this pull request as ready for review April 7, 2024 10:15
@Hisoka-X
Copy link
Member

Hisoka-X commented Apr 7, 2024

Shall we add test case?

@hailin0
Copy link
Contributor Author

hailin0 commented Apr 8, 2024

Shall we add test case?

Ok, I'll add

@EricJoy2048 EricJoy2048 merged commit 4b6c13e into apache:dev May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuchunfu wuchunfu wuchunfu approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@lightzhao lightzhao lightzhao approved these changes

Assignees
No one assigned
Labels
approved bugfix jdbc oracle reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hailin0 @Hisoka-X @wuchunfu @EricJoy2048 @lightzhao