[Fix][Connector-V2] Field information lost during Paimon DataType and SeaTunnel Column conversion #6767
Conversation
# Conflicts: # docs/en/connector-v2/sink/Doris.md
|
Any test case? |
OK, thanks for your review. I'm going to add some test cases |
xiaochen-zhou
changed the title
| @@ -320,7 +321,7 @@ public static SeaTunnelRow convert(InternalRow rowData, SeaTunnelRowType seaTunn | |||
| break; | |||
| default: | |||
| throw new PaimonConnectorException( | |||
| CommonErrorCodeDeprecated.UNSUPPORTED_DATA_TYPE, | |||
| CommonErrorCode.UNSUPPORTED_DATA_TYPE, | |||
There was a problem hiding this comment.
Please throw common error by use this method.
There was a problem hiding this comment.
Please throw common error by use this method.
done.
| public static SeaTunnelRuntimeException unsupportedDataType( | ||
| String identifier, String dataType) { | ||
| Map<String, String> params = new HashMap<>(); | ||
| params.put("identifier", identifier); | ||
| params.put("dataType", dataType); | ||
| return new SeaTunnelRuntimeException(UNSUPPORTED_DATA_TYPE_SIMPLE, params); | ||
| } |
There was a problem hiding this comment.
Please reuse public static SeaTunnelRuntimeException unsupportedDataType( String identifier, String dataType, String field) . Because we should make sure user know which field can not supported.
| return new SeaTunnelRuntimeException(UNSUPPORTED_ARRAY_GENERIC_TYPE, params); | ||
| } | ||
|
|
||
| public static SeaTunnelRuntimeException unsupportedRowKind(String identifier, String rowKind) { |
There was a problem hiding this comment.
we need tableId when invoke unsupportedRowKind method.
There was a problem hiding this comment.
we need tableId when invoke
unsupportedRowKindmethod.
OK, I will optimize the code based on your suggestions
There was a problem hiding this comment.
we need tableId when invoke
unsupportedRowKindmethod.OK, I will optimize the code based on your suggestions
done.
| public static SeaTunnelRuntimeException unsupportedArrayGenericType( | ||
| String identifier, String dataType) { | ||
| Map<String, String> params = new HashMap<>(); | ||
| params.put("identifier", identifier); | ||
| params.put("dataType", dataType); | ||
| return new SeaTunnelRuntimeException(UNSUPPORTED_ARRAY_GENERIC_TYPE, params); | ||
| } |
# Conflicts: # seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonError.java # seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonErrorCode.java
xiaochen-zhou
force-pushed
the
paimon_catalog_basetype
branch
from
2c327bf
to
3915e36
Compare
| @@ -445,9 +496,8 @@ public SeaTunnelDataType<?> visit(RowType rowType) { | |||
|
|
|||
| @Override | |||
| protected SeaTunnelDataType defaultMethod(DataType dataType) { | |||
There was a problem hiding this comment.
@Hisoka-X This defaultMethod method inherited from paimon seems to be difficult to obtain the fieldname.
There was a problem hiding this comment.
Please put fieldname as UNKNOWN.
| builder.length(column.getColumnLength()); | ||
| return builder.build(); | ||
| case DECIMAL: | ||
| int precision = |
There was a problem hiding this comment.
In some cases, the precision and scale obtained here may be 0, and you must handle this situation to achieve better compatibility.
Purpose of this pull request
Field information lost during Paimon DataType and SeaTunnel Column conversion, such as: field name
Does this PR introduce any user-facing change?
no
How was this patch tested?
exists test
Check list
New License Guide
release-note.