[Hotfix][Postgres-CDC] Fix read data missing when restore #6785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
force-pushed
the
dev-fix-pg-cdc-missing-data
branch
from
44f3804
to
fca70f3
Compare
hailin0
commented
Apr 30, 2024
Comment on lines
+194
to
+195
| // create the slot if it doesn't exist, otherwise update slot to add new | ||
| // table(job restore and add table) |
There was a problem hiding this comment.
|
How about add a test case for this scene? |
1. The job was not added new tables into `publication` before start to snapshot read. 2. Delete of database logs did not use checkpoint offset.
hailin0
force-pushed
the
dev-fix-pg-cdc-missing-data
branch
from
fca70f3
to
cd2acad
Compare
hailin0
commented
May 6, 2024
| @@ -113,7 +116,7 @@ public void pollNext(Collector<T> output) throws Exception { | |||
|
|
|||
| @Override | |||
| public void notifyCheckpointComplete(long checkpointId) throws Exception { | |||
| dataSourceDialect.notifyCheckpointComplete(checkpointId); | |||
There was a problem hiding this comment.
hailin0
changed the title
wuchunfu
approved these changes
May 7, 2024
EricJoy2048
approved these changes
May 11, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
publicationbefore start to snapshot read.Does this PR introduce any user-facing change?
No
How was this patch tested?
Check list
New License Guide
release-note.