[compiler v2] Emulating some unexpected v1 borrow behavior #13314
+107
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13314 +/- ##
=========================================
- Coverage 33.0% 32.9% -0.1%
=========================================
Files 1768 1768
Lines 339266 339263 -3
=========================================
- Hits 111995 111840 -155
- Misses 227271 227423 +152 ☔ View full report in Codecov by Sentry. |
rahxephon89
approved these changes
May 20, 2024
| // conditions and produce an error ad-hoc. | ||
| if is_mut | ||
| && !self.alive.after.contains_key(&dest) | ||
| //&& self.state.children(&label).any(|e| e.target != child) |
There was a problem hiding this comment.
maybe remove this commented code?
|
|
||
| // Preprocessing: check borrow safety of the currently active borrow graph for read ref, | ||
| // write ref, and function calls. | ||
| // Preprocessing: check borrow safety of the currently active borrow graph for |
There was a problem hiding this comment.
Since release_refs_not_alive_after is called after handling this instr, this is not needed anymore?
There was a problem hiding this comment.
It was always like a defensive meaure 'if something has been not release by now, do it now', but it should not be required as releasing happens (before and after) at the end of each instruction, with or without this new function. I removed it and verified everything works like before.
The difference is really that the cleanup at the end and what you did with your 'release before write' is now unified in release_refs_not_alive_after. The special check whether the write destination is not a ref is also not longer needed, by doing the releasing after the output graph has been created.
brmataptos
changed the title
brmataptos
approved these changes
May 21, 2024
| } | ||
| } | ||
|
|
||
| // Some instructions may not have release inputs, do so now. The operation |
There was a problem hiding this comment.
And if this is operation is idempotent, you should document that on the function, not so necessary here.
wrwg
force-pushed
the
wrwg/borrow
branch
2 times, most recently
from
8439986
to
cc88ce9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Fixes #12781 This also refactors and simplifies the releasing of references before write operations. I initially thought this was the problem but it wasn't, anyway the refactoring simplifies the code a bit.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12781
This also refactors and simplifies the releasing of references before write operations. I initially thought this was the problem but it wasn't, anyway the refactoring simplifies the code a bit.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
New baseline test