Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add OpenAI env var attribution for opanai embedding function #2214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TALLEC-Scott
Copy link

By default set the OpenAIEmbeddingFunction API key to what is in the corresponding environment variable. This mimics the openai lib's behavior.

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • by default apply the OPENAI_API_KEY env var to the openai.api_key
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

By default set the OpenAIEmbeddingFunction API key to what is in the corresponding environment variable. This mimics the openai lib's behavior.
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 2:21pm

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@TALLEC-Scott TALLEC-Scott changed the title Update embedding_functions.py feat(embedding_functions.py) : add OpenAI env var attribution May 18, 2024
@TALLEC-Scott TALLEC-Scott changed the title feat(embedding_functions.py) : add OpenAI env var attribution [ENH] add OpenAI env var attribution for opanai embedding function May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant