Update tunes data when new tunes data is provided
#2720
+113
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIK, when you update block using `editor.blocks.update` method, only `data` attribute is merged and updated. I believe `tunes` data should be updated if provided.
w99910
requested review from
neSpecc,
gohabereg,
TatianaFomina and
ilyamore88
as code owners
neSpecc
reviewed
May 17, 2024
Update `tunes` data when new `tunes` data is provided
I have added a test. In order to prevent breaking change, I decided to add new parameter called |
neSpecc
requested changes
May 17, 2024
neSpecc
reviewed
Jun 8, 2024
src/components/modules/api/blocks.ts
Outdated
| */ | ||
| public update = async (id: string, data: Partial<BlockToolData>): Promise<BlockAPIInterface> => { | ||
| public update = async (id: string, data: Partial<BlockToolData>, tunes?: {[name: string]: BlockTuneData}): Promise<BlockAPIInterface> => { |
There was a problem hiding this comment.
What if I want to update only tunes? I think the data should be optional as well.
One of "tune" or "data" should be provided.
There was a problem hiding this comment.
@neSpecc I have updated the code. I think it should just return provided block if neither new block data nor tunes data is provided in order to skip redundant and unnecessary update. What do you think about it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK, when you update block using
editor.blocks.updatemethod, onlydataattribute is merged and updated. I believetunesdata should be updated if provided.