-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes cleanup command from run.sh after running rbac example #1226
base: 7.5.x
Are you sure you want to change the base?
Conversation
Remove cleanup after run.
security/rbac/scripts/run.sh
Outdated
@@ -44,4 +44,4 @@ sleep 1 | |||
./enable-rbac-ksqldb-server.sh | |||
./enable-rbac-control-center.sh | |||
|
|||
./cleanup.sh | |||
# ./cleanup.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking back at history, run.sh
was always intended to clean up after itself, but I don't see why it couldn't leave services running. That would also work better with the docs page that goes with the example since the step after Run example
is Stop example
just delete the line rather than comment out though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I agree with @davetroiano
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup should be done separately for actually "running" and playing with the examples.
Deleted the line as suggested. Commented initially because it was like that in previous history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go against the 7.4.0-post
branch
security/rbac/scripts/run.sh
Outdated
@@ -44,4 +44,4 @@ sleep 1 | |||
./enable-rbac-ksqldb-server.sh | |||
./enable-rbac-control-center.sh | |||
|
|||
./cleanup.sh | |||
# ./cleanup.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I agree with @davetroiano
Will raise separate PR for it. Because the branch history is different now. |
|
Description
Removes cleanup after running rbac script
run.sh
as this voids above commands.Author Validation
[X] security/rbac
Reviewer Tasks
Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.