Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🇬 refactor: Update default Google Models and Parameters #2782

Merged
merged 3 commits into from
May 22, 2024

Conversation

achhabra2
Copy link
Contributor

@achhabra2 achhabra2 commented May 18, 2024

Summary

Gemini models default to different parameter settings. Eg. the latest models have temperature from 0-2 with default of 1. Max output defaults to 8192, top_p defaults to 0.95. The default model and parameters are for chat-bison which is pretty much a deprecated model that no one uses. My suggestion is to change the default model along with the default parameters to be more in line with the current offerings. Most LibreChat users will use aistudio instead of Vertex anyway, where bison models would be irrelevant.

This PR changes the default model from chat-bison to gemini, as well as updates the default parameters. I also updated the .env.example with the latest / greatest model tags as of 05/18. This should result in a better default experience for most users. I also removed the the PALM / bison family of models from .env.example as they have been mostly superseded by Gemini.

The resulting code is more consistent with the other providers, and would be easier to maintain moving forward. Incoming PR to update documentation as well. LibreChat-AI/librechat.ai#30

Change Type

Please delete any irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Translation update

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

Test Configuration:

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@danny-avila danny-avila changed the title Update default Google models and parameters 🇬 refactor: Update default Google Models and Parameters May 22, 2024
@danny-avila danny-avila merged commit 9d8fd92 into danny-avila:main May 22, 2024
2 checks passed
@danny-avila
Copy link
Owner

thanks!

danny-avila pushed a commit that referenced this pull request May 27, 2024
* Update Google default model and parameters

* Update .env.example Vertex AI Models to reflect latest version and deprecate bison family

* Update Vertex AI model list in .env.example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants