trie: add batch get operation #29724
Closed
+327
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
reviewed
May 8, 2024
| return result, nil | ||
| } | ||
|
|
||
| // getBatch resolves a batch of trie values simultenaously. |
|
After a number of benchmarks, there's no meaningful difference in speed. I don't really want to spend much time on this and I'd wager it bitrots fast. Might as well get rid of it and maybe revisit later if there's a reason to believe it matters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for now, investigating whether we could sneak some concurrency in somehow, but first the non concurrent batch versions.