-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build-properties] Add field to enable/disable privacy manifest aggregation #28646
Conversation
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
const { modResults: iosModResultsEnabled } = await compileMockModWithResultsAsync( | ||
{}, | ||
{ | ||
plugin: withBuildProperties, | ||
pluginProps: { ios: { ccache: true } }, | ||
pluginProps: { ios: { ccacheEnabled: true } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test looked incorrect, typechecking was failing on it
Why
There are a few issues right now with privacy manifest aggregation (facebook/react-native#44410, facebook/react-native#44402, facebook/react-native#44402) that I expect will be fixed in React Native 0.74.2, but in order to ensure that this doesn't break builds I've disabled it by default and added this build property to allow folks to toggle it on. We can switch on by default when 0.74.2 is released and proven to handle some edge cases better.
How
Same old process for adding a new property
Test Plan
Run tests
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).