Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prefabPublishing for aar on android platform #1193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmzy
Copy link

@cmzy cmzy commented Nov 22, 2023

Enable prefabPublishing for aar on android platform

This will enable we can use aar by prefab

Test Plan

NAN

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 22, 2023
@dannysu
Copy link
Contributor

dannysu commented Nov 30, 2023

hi @cmzy, I'm less familiar with the Android AAR import. Do you have an example project that uses the new AAR from your diff that I can look at?

Thanks

@cmzy
Copy link
Author

cmzy commented Dec 1, 2023

familiar

here is the documents https://developer.android.com/build/dependencies#using-native-dependencies

If we enable prefab in AAR, that means we don't need copy the header and libs , and more easy to use. and this is the Best Practices in android if someone want to push a native library.

@dannysu
Copy link
Contributor

dannysu commented Dec 6, 2023

@cmzy
I gave this PR a quick try. It seems like the generated hermesConfig.cmake tries to reference liblibhermes.so, which doesn't exist, rather than the libhermes.so packaged in the AAR. So I can't actually get a project to build yet.

Do you have an example project that successfully compiles using header imports from the AAR with the new prefab settings? If so, would you be able to share that?
Thanks

@cmzy
Copy link
Author

cmzy commented Dec 7, 2023

@cmzy I gave this PR a quick try. It seems like the generated hermesConfig.cmake tries to reference liblibhermes.so, which doesn't exist, rather than the libhermes.so packaged in the AAR. So I can't actually get a project to build yet.

Do you have an example project that successfully compiles using header imports from the AAR with the new prefab settings? If so, would you be able to share that? Thanks

Could you share me how did you try that ? It is ok when I try to build it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants