Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request bundles with excludeSources=true and sourcePaths=url-server in Fusebox experiment #44444

Closed
wants to merge 1 commit into from

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented May 7, 2024

Summary: Changelog: [Internal]

Differential Revision: D56952065

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56952065

@analysis-bot
Copy link

analysis-bot commented May 7, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,388 +9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,579 +7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: deee037
Branch: main

motiz88 added a commit to motiz88/react-native that referenced this pull request May 7, 2024
… Fusebox experiment (facebook#44444)

Summary:

Changelog: [Internal] - Request bundles with `excludeSource=true` and `sourcePaths=url-server`.

Changes RN's bundle client to request more efficient source maps from Metro by relying on lazy-fetching of source contents.

NOTE: Requires a Metro version with D56952064 and D56952063 (not yet released on npm) to work properly.

Differential Revision: D56952065
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56952065

motiz88 added a commit to motiz88/react-native that referenced this pull request May 8, 2024
… Fusebox experiment (facebook#44444)

Summary:

Changelog: [Internal] - Request bundles with `excludeSource=true` and `sourcePaths=url-server`.

Changes RN's bundle client to request more efficient source maps from Metro by relying on lazy-fetching of source contents.

NOTE: Requires a Metro version with D56952064 and D56952063 (not yet released on npm) to work properly.

Reviewed By: robhogan

Differential Revision: D56952065
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56952065

motiz88 added a commit to motiz88/react-native that referenced this pull request May 8, 2024
… Fusebox experiment (facebook#44444)

Summary:

Changelog: [Internal] - Request bundles with `excludeSource=true` and `sourcePaths=url-server`.

Changes RN's bundle client to request more efficient source maps from Metro by relying on lazy-fetching of source contents.

NOTE: Requires a Metro version with D56952064 and D56952063 (not yet released on npm) to work properly.

Reviewed By: robhogan

Differential Revision: D56952065
motiz88 added a commit to motiz88/react-native that referenced this pull request May 8, 2024
…-server in Fusebox experiment (facebook#44444)

Summary:

Changelog: [Internal] - Request bundles with `excludeSource=true` and `sourcePaths=url-server`.

Changes RN's bundle client to request more efficient source maps from Metro by relying on lazy-fetching of source contents.

NOTE: Requires a Metro version with D56952064 and D56952063 (not yet released on npm) to work properly.

Reviewed By: robhogan

Differential Revision: D56952065
motiz88 added a commit to motiz88/react-native that referenced this pull request May 8, 2024
… Fusebox experiment (facebook#44444)

Summary:

Changelog: [Internal] - Request bundles with `excludeSource=true` and `sourcePaths=url-server`.

Changes RN's bundle client to request more efficient source maps from Metro by relying on lazy-fetching of source contents.

NOTE: Requires a Metro version with D56952064 and D56952063 (not yet released on npm) to work properly.

Reviewed By: robhogan

Differential Revision: D56952065
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56952065

… Fusebox experiment (facebook#44444)

Summary:

Changelog: [Internal] - Request bundles with `excludeSource=true` and `sourcePaths=url-server`.

Changes RN's bundle client to request more efficient source maps from Metro by relying on lazy-fetching of source contents.

NOTE: Requires a Metro version with D56952064 and D56952063 (not yet released on npm) to work properly.

Reviewed By: robhogan

Differential Revision: D56952065
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56952065

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6473906.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

This pull request was successfully merged by @motiz88 in 6473906.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants