-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOS] Remove redundant fmt dependencies #44449
base: main
Are you sure you want to change the base?
Conversation
Base commit: be09d12 |
|
I can take a look. I was looking at cleaning up the header search paths too |
@NickGerleman It looks I can remove the header search paths for fmt, and the dependency/header search paths for DoubleConversion too. One thing I'm not clear about is that I think codegen (which generates |
@NickGerleman I did some testing. Removing the |
Summary:
fmt is required by many different podspecs, but is only used by Folly. I verified this by removing fat altogether and seeing what build errors I got. Cocoapods supports transitive dependencies, so let's simplify the build graph a bit and mark fmt as only a dependency of folly.
Changelog:
[IOS] [CHANGED] - Remove redundant fmt dependencies
Test Plan:
CI should pass. Local build of RNTester works.