Teach CSSTokenizer about function-token, parens, comma #44450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57047886 |
Base commit: deee037 |
Summary:
Every CSS prop at this sparse stage is represented as an enum, and each enum can be specialized to different types, according to the global CSS property table.
With this change, we add a string name to each property table entry that we use to generate a function to be able to set CSS value strings, against property name strings. Like `declaredStyle.set("aspectRatio", "4 / 3")`.
I was considering specializing this a bit, to allow DeclaredStyles which only support a subset of CSS props. E.g. so `ParagraphShadowNode` has a more derived declared style than `LayoutableShadowNode` does. But, I am not sure the best way yet to make that compose nicely.
Changelog: [internal]
Differential Revision: D57039255
Summary: Adding some of the tokenization needed for things like `transform` and `filter`. Parsing will be a bit trickier with the model currently built up. Changelog: [Internal] Differential Revision: D57047886
NickGerleman
force-pushed
the
export-D57047886
branch
from
6a641fd
to
25e6b46
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57047886 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 8, 2024
Summary: Adding some of the tokenization needed for things like `transform` and `filter`. Parsing will be a bit trickier with the model currently built up. Changelog: [Internal] Differential Revision: D57047886
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 8, 2024
Summary: Adding some of the tokenization needed for things like `transform` and `filter`. Parsing will be a bit trickier with the model currently built up. Changelog: [Internal] Differential Revision: D57047886
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 8, 2024
…ebook#44450) Summary: Adding some of the tokenization needed for things like `transform` and `filter`. Parsing will be a bit trickier with the model currently built up. Changelog: [Internal] Differential Revision: D57047886
|
This pull request has been merged in 7003e35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding some of the tokenization needed for things like
transformandfilter. Parsing will be a bit trickier with the model currently built up.Changelog: [Internal]
Differential Revision: D57047886