Parse raw filter props #44455
Closed
Parse raw filter props #44455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54640629 |
Summary: This works similar to how `transform` is parsed in that it sets tags on the View to actually update the prop when all the prop setters are done being called since the parsing of the array is not very trivial. Besides that it is pretty simple and just calls into `FilterHelper` and uses `setRenderEffect`: https://developer.android.com/reference/android/view/View#setRenderEffect(android.graphics.RenderEffect). That API is only exposed in version 31 of the SDK so it is gated accordingly. Reviewed By: NickGerleman Differential Revision: D54640600
Summary: tsia Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D56847475
Summary: Title says it all. Right now this ignores drop-shadow as that will be implemented later. Some of this code will need to be adjusted as it is the one filter that takes multiple amounts. But I feel that can be amended later when we get there - after all the `amount` parsing code is just casting to a float at the moment, so we are not locking ourselves into anything. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D54640629
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
May 7, 2024
Summary: Title says it all. Right now this ignores drop-shadow as that will be implemented later. Some of this code will need to be adjusted as it is the one filter that takes multiple amounts. But I feel that can be amended later when we get there - after all the `amount` parsing code is just casting to a float at the moment, so we are not locking ourselves into anything. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D54640629
joevilches
force-pushed
the
export-D54640629
branch
from
76f66f4
to
a4eef11
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54640629 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
May 7, 2024
Summary: Title says it all. Right now this ignores drop-shadow as that will be implemented later. Some of this code will need to be adjusted as it is the one filter that takes multiple amounts. But I feel that can be amended later when we get there - after all the `amount` parsing code is just casting to a float at the moment, so we are not locking ourselves into anything. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D54640629
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
May 7, 2024
Summary: Title says it all. Right now this ignores drop-shadow as that will be implemented later. Some of this code will need to be adjusted as it is the one filter that takes multiple amounts. But I feel that can be amended later when we get there - after all the `amount` parsing code is just casting to a float at the moment, so we are not locking ourselves into anything. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D54640629
Base commit: be09d12 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
May 7, 2024
Summary: Title says it all. Right now this ignores drop-shadow as that will be implemented later. Some of this code will need to be adjusted as it is the one filter that takes multiple amounts. But I feel that can be amended later when we get there - after all the `amount` parsing code is just casting to a float at the moment, so we are not locking ourselves into anything. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D54640629
|
This pull request has been merged in f340e6e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Title says it all. Right now this ignores drop-shadow as that will be implemented later. Some of this code will need to be adjusted as it is the one filter that takes multiple amounts. But I feel that can be amended later when we get there - after all the
amountparsing code is just casting to a float at the moment, so we are not locking ourselves into anything.Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D54640629