Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS autolinking.rb needs to export react_native_pods.rb #44462

Closed
wants to merge 4 commits into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented May 7, 2024

Summary:
Users using the new react-native/scripts/cocoapods/autolinking.rb script will expect all of the helper methods previously exposed throug react_native_pods.rb.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Differential Revision: D57066094

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 7, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57066094

blakef added a commit to blakef/react-native that referenced this pull request May 7, 2024
Summary:

Users using the new `react-native/scripts/cocoapods/autolinking.rb` script will expect all of the helper methods previously exposed throug `react_native_pods.rb`.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Differential Revision: D57066094
blakef added a commit to blakef/react-native that referenced this pull request May 7, 2024
Summary:

Users using the new `react-native/scripts/cocoapods/autolinking.rb` script will expect all of the helper methods previously exposed throug `react_native_pods.rb`.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Differential Revision: D57066094
blakef added 4 commits May 7, 2024 15:54
Summary:

Users would have to do this by manipulating the environment before.

Changelog: [Internal]

Differential Revision: D57067036
Summary:

Contains a *light* wrapper to help launch Metro and build bundles or wait for localhost requests against Metro's dev-server. 

Changelog: [Internal]

Differential Revision: D57067040
Summary:

Helper methods to help the cli grab system state, devices and run react-native/core-cli-utils tasks using Listr.

Changelog: [Internal]

Differential Revision: D57067037
Summary:

Users using the new `react-native/scripts/cocoapods/autolinking.rb` script will expect all of the helper methods previously exposed throug `react_native_pods.rb`.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Differential Revision: D57066094
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57066094

blakef added a commit to blakef/react-native that referenced this pull request May 7, 2024
…cebook#44462)

Summary:

Users using the new `react-native/scripts/cocoapods/autolinking.rb` script will expect all of the helper methods previously exposed throug `react_native_pods.rb`.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Differential Revision: D57066094
blakef added a commit to blakef/react-native that referenced this pull request May 7, 2024
…cebook#44462)

Summary:

Users using the new `react-native/scripts/cocoapods/autolinking.rb` script will expect all of the helper methods previously exposed throug `react_native_pods.rb`.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Differential Revision: D57066094
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,262 +8
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,553 +6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: be09d12
Branch: main

blakef added a commit to blakef/react-native that referenced this pull request May 8, 2024
Summary:

Users using the new `react-native/scripts/cocoapods/autolinking.rb` script will expect all of the helper methods previously exposed throug `react_native_pods.rb`.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Reviewed By: cipolleschi

Differential Revision: D57066094
blakef added a commit to blakef/react-native that referenced this pull request May 8, 2024
Summary:

Users using the new `react-native/scripts/cocoapods/autolinking.rb` script will expect all of the helper methods previously exposed throug `react_native_pods.rb`.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Reviewed By: cipolleschi

Differential Revision: D57066094
blakef added a commit to blakef/react-native that referenced this pull request May 8, 2024
Summary:

Users using the new `react-native/scripts/cocoapods/autolinking.rb` script will expect all of the helper methods previously exposed throug `react_native_pods.rb`.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Reviewed By: cipolleschi

Differential Revision: D57066094
blakef added a commit to blakef/react-native that referenced this pull request May 8, 2024
…cebook#44462)

Summary:

Users using the new `react-native/scripts/cocoapods/autolinking.rb` script will expect all of the helper methods previously exposed throug `react_native_pods.rb`.

This was an oversight.

Changelog: [iOS][Fixed] exposes react_native_pods methods through autolinking.rb

Reviewed By: cipolleschi

Differential Revision: D57066094
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6b56fb0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants