Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: remove marketing from skyhigh #9666

Merged
merged 2 commits into from
May 20, 2024

Conversation

jsiegel-supplyframe
Copy link
Contributor

Details

removing advertising copy from documentation


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • [ X] The documentation has been updated
  • The documentation has been formatted (make website)

removing advertising copy from documentation

Signed-off-by: jsiegel-supplyframe <120349776+jsiegel-supplyframe@users.noreply.github.com>
@jsiegel-supplyframe jsiegel-supplyframe requested a review from a team as a code owner May 9, 2024 19:06
Copy link

netlify bot commented May 9, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit e642738
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/664bd472daa00200084d213f

Copy link

netlify bot commented May 9, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit e642738
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/664bd472bd01f20008df6956
😎 Deploy Preview https://deploy-preview-9666--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.96%. Comparing base (8b74b83) to head (e642738).
Report is 50 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9666       +/-   ##
===========================================
- Coverage   92.39%   50.96%   -41.43%     
===========================================
  Files         704      706        +2     
  Lines       34396    34356       -40     
===========================================
- Hits        31781    17511    -14270     
- Misses       2615    16845    +14230     
Flag Coverage Δ
e2e 49.58% <ø> (-0.08%) ⬇️
integration 25.34% <ø> (-0.03%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanberry
Copy link
Contributor

Thanks @jsiegel-supplyframe, I agree about removing that section. The original contributor can rewrite it in a more straightforward, technical way if desired.

Can you run lint-prettier and push again, please? The build is failing on that check. You can safely ignore the other four fails.

@tanberry tanberry added the status/awaiting-contributor Awaiting a response from the contributor label May 15, 2024
@BeryJu BeryJu changed the title Update index.md website/docs: remove marketing from skyhigh May 20, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit 644090d into goauthentik:main May 20, 2024
59 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/awaiting-contributor Awaiting a response from the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants