Canvas: Chore clean up more betterer warnings #88010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarrs
added
type/chore
area/panel/canvas
nmarrs
requested review from
Develer and
adela-almasan
and removed request for
a team
nmarrs
commented
May 17, 2024
| @@ -11,7 +11,7 @@ export const PanZoomHelp = ({}: StandardEditorProps<string, unknown, unknown, un | |||
|
|
|||
| return ( | |||
| <> | |||
| <HorizontalGroup className={styles.hGroup}> | |||
| <Stack direction="row"> | |||
There was a problem hiding this comment.
Pics of this change... currently no way to pass a custom class down to Stack 🤔
Before
After
There was a problem hiding this comment.
It's a bit less tidy but doesn't seem like a big deal.
nmarrs
commented
May 17, 2024
| @@ -3,276 +3,253 @@ import { css } from '@emotion/react'; | |||
| import { GrafanaTheme2 } from '@grafana/data'; | |||
|
|
|||
| export function getGlobalStyles(theme: GrafanaTheme2) { | |||
| return css` | |||
There was a problem hiding this comment.
This is the change I'm most worried about haha, but I think it should be ok.. but would appreciate a review of this (cc @adela-almasan 😬)
codeincarnate
approved these changes
May 20, 2024
3 tasks
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up almost all of the remaining betterer issues
The last two files / betterer issues will require a bit more extensive refactor that I will follow-up with to get rid of canvas's barrel files
Related to #87477