Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cast to float32 and float16 when using CPU for pushing to HF #707

Merged
merged 2 commits into from
May 21, 2024

Conversation

pascal-pfeiffer
Copy link
Collaborator

I think recent changes in 3rd party dependencies make this cast to float32 and float16 obsolete and CPU seems to be able to handle it.

closes #702

@pascal-pfeiffer
Copy link
Collaborator Author

I found this as an explanation why the cast to float32/16 was added.
Wdyt, shall we just remove and see when it breaks or wrap in a try/except block? Ideally, we will add a selection for target precision (or quantization) anyway.

@psinger
Copy link
Collaborator

psinger commented May 21, 2024

I found this as an explanation why the cast to float32/16 was added. Wdyt, shall we just remove and see when it breaks or wrap in a try/except block? Ideally, we will add a selection for target precision (or quantization) anyway.

yes I think we can see when it breaks

@pascal-pfeiffer pascal-pfeiffer merged commit a5c5d5e into main May 21, 2024
4 checks passed
@pascal-pfeiffer pascal-pfeiffer deleted the pp/allow_bfloat16_cpu branch May 21, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants