Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix variable name and inference config. #374

Closed
wants to merge 2 commits into from

Conversation

ArkiZh
Copy link

@ArkiZh ArkiZh commented May 7, 2024

  1. Fix wrong variable name: enable_flashattn to enable_flash_attn.
  2. Fix model dtype: From default to bf16.

@zhengzangw
Copy link
Collaborator

Thank you for your PR. Your suggestion is valuable. However, we are now conducting a transformation of our model to huggingface's conversion. Thus, we will use another format and close your PR for now.

@zhengzangw zhengzangw closed this May 9, 2024
@ArkiZh
Copy link
Author

ArkiZh commented May 11, 2024

Thank you for your PR. Your suggestion is valuable. However, we are now conducting a transformation of our model to huggingface's conversion. Thus, we will use another format and close your PR for now.

Really looking forward to the transition to the Hugging Face format, it's indeed a great move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants