Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dekstop Revamp #2877

Merged
merged 47 commits into from
May 29, 2024
Merged

feat: Dekstop Revamp #2877

merged 47 commits into from
May 29, 2024

Conversation

urmauur
Copy link
Contributor

@urmauur urmauur commented May 8, 2024

Describe Your Changes

Fixes Issues

#2721
#2775
#2343
#2474
#2476
#2779
#2333
#2117
#2475
#2477
#2473
#1192
#2085

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur requested review from louis-jan and namchuai and removed request for louis-jan May 8, 2024 02:50
@urmauur urmauur self-assigned this May 8, 2024
@urmauur urmauur added the type: feature request A new feature label May 8, 2024
@urmauur urmauur requested a review from louis-jan May 8, 2024 02:51
@Van-QA
Copy link
Contributor

Van-QA commented May 8, 2024

hi @urmauur,

  1. Can you help us correct this scroll bar on Windows ❌
    image

The scroll bar for Hub is looking good ✅ (added here for your reference)
image

Linking to #2779

@urmauur
Copy link
Contributor Author

urmauur commented May 9, 2024

@Van-QA thanks for early feedback, I'll be make sure we are good on windows

@Van-QA
Copy link
Contributor

Van-QA commented May 9, 2024

Missing model selector in local API server
image
Looking at the Figma, the UI is blank https://www.figma.com/file/DYfpMhf8qiSReKvYooBgDV/Jan-App-(version-2)?type=design&node-id=2502-78724&mode=design so I'm not sure what is the expectation 🙏

@urmauur
Copy link
Contributor Author

urmauur commented May 9, 2024

Missing model selector in local API server image Looking at the Figma, the UI is blank https://www.figma.com/file/DYfpMhf8qiSReKvYooBgDV/Jan-App-(version-2)?type=design&node-id=2502-78724&mode=design so I'm not sure what is the expectation 🙏

this has not yet been touched, on since I have a lot of changes, but I take this note for me

@Van-QA
Copy link
Contributor

Van-QA commented May 14, 2024

image
Use button of dark mode ❌

@Van-QA Van-QA merged commit faa09bd into dev May 29, 2024
7 checks passed
@Van-QA Van-QA deleted the feat/desktop-revamp branch May 29, 2024 06:37
@github-actions github-actions bot added this to the v.0.5.0 🍵 Bubur Ayam milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants