-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet/volumeManager: improve unit test coverage #124911
base: master
Are you sure you want to change the base?
kubelet/volumeManager: improve unit test coverage #124911
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TommyStarK The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm trying to get involved and contribute again to K8s, so to get back on track I thought I'd start by improving unit test code coverage. I apologize in advance if some of the tests/cases added are irrelevant. I lack a lot of knowledge in this area. I hope it will be useful anyway. |
af2bc17
to
847f992
Compare
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
847f992
to
afe3ede
Compare
/triage accepted |
/kind cleanup
What this PR does / why we need it:
If applied this commit will improve unit test coverage of
pkg/kubelet/volumemanager
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: