Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1042
Change
Migrate Ollama module from Gson to Jackson. But we still need to migrate
langchain4j-core
andopenai4j
too.Note that there are three things confused me(these issues exist in original ollama module):
assertThat(tokenUsage.inputTokenCount()).isEqualTo(35)
) failed because of the differencet count of input tokens. I don't know whether it's because Ollama's update. Now I correct itshould_propagate_failure_to_handler_onError
inStreaming{xxx}ModelIT
failed in my local becauseNullPointerException
do not have any message. Is it a problem in my local environment?Testcontainers
's problem.I'm not sure if these problems are due to my local environment, so if you have any suggestions or solutions, please let me know!
General checklist
Checklist for adding new model integration
Checklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreIT
that extends from eitherEmbeddingStoreIT
orEmbeddingStoreWithFilteringIT
Checklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStore
works correctly with the data persisted using the latest released version of LangChain4j