fix(electron): flaky startup if stderr comes in too fast #30855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"1 flaky27012 passed, 610 skipped Merge workflow run. |
mxschmitt
approved these changes
May 20, 2024
|
|
||
| const nodeMatch = await waitForLine(progress, launchedProcess, /^Debugger listening on (ws:\/\/.*)$/); | ||
| const nodeMatch = await nodeMatchPromise; |
There was a problem hiding this comment.
nit: move nodeMatchPromise to the end and await immediately (one less var to declare)?
pavelfeldman
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium's
DevTools listening onmessage sometimes arrives before Playwright is finished connecting to Node. Without this patch, it would miss the message and fail to connect.