Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-conversation-sidebar - Restore mistakenly-hidden links #7350

Merged

Conversation

DenverCoder1
Copy link
Contributor

@DenverCoder1 DenverCoder1 commented May 7, 2024

Closes #7235

  • Data action of create branch corrected from click:create-issue-branch#openDialog to click:create-branch#openDialog so that it will be added to the heading when the section is collapsed
  • Section will not be hidden or collapsed if the "Open in Workspace" button is in the Development section (currently a feature in limited technical preview)

Test URLs

Affects Issues pages

Screenshot

Not logged in:

image


Logged in, no edit access, no Copilot Workspace access, no linked issues:

image


Logged in, no edit access, no Copilot Workspace access, has linked issues:

image


Logged in, has edit access, no Copilot Workspace access:

image


Logged in, no edit access, has Copilot Workspace access:

image


Logged in, has edit access, has Copilot Workspace access:

image


@Araxeus
Copy link

Araxeus commented Jun 1, 2024

Could we get this merged before the next release? @fregante
I didn't realize I had workspace tech preview access because this bug just hid it :(

@fregante fregante changed the title clean-conversation-sidebar: Fix visibility of create branch and Workspace links clean-conversation-sidebar - Fix visibility of create branch and Workspace links Jun 2, 2024
@fregante fregante added the bug label Jun 2, 2024
@fregante fregante merged commit f35a68c into refined-github:main Jun 2, 2024
12 checks passed
@fregante fregante changed the title clean-conversation-sidebar - Fix visibility of create branch and Workspace links clean-conversation-sidebar - Restore mistakenly-hidden links Jun 2, 2024
@fregante
Copy link
Member

fregante commented Jun 2, 2024

Thank you @DenverCoder1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

clean-conversation-sidebar breaks "Create a branch from issue "
4 participants