-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): disable vendored openssl #16761
Conversation
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So by default we will dynamic link openssl, and static link if OPENSSL_STATIC=1
right? This solution is generally acceptable to me, but some points:
- Dockerfile might also need to be updated (or not?). And please run the pipeline to test docker & binary release.
- Homebrew formula might need to be updated.
- We met compile issue with openssl several times (and developers are not good at solving it!) e.g., cannot build
rdkakfa-sys
with M1 Mac according to developer guide #5739 and compile error when openssl@3 is installed in the system #11467. But I'm OK to try it again.. - Why not always static link? e.g.,
OPENSSL_STATIC=1
inbuild.rs
. So that we don't need to manage many scripts.
openssl@3 in homebrew is not keg-only any more. So perhaps the experience will be better. |
I see the openssl3 dependency in the formula. So I guess it's just fine?
I tried to set this env variable in build.rs in workspace-config, but it didn't work. |
Signed-off-by: Runji Wang <wangrunji0408@163.com>
No idea why the e2e test is always timed out. 🤪 |
BTW, I'm thinking BTW, the timeout in this PR is quite strange. From the trending, not sure whether we should increase timeout https://rw-buildkite-stats.streamlit.app/ |
Signed-off-by: Runji Wang <wangrunji0408@163.com>
a759a7e
to
4249f1c
Compare
Signed-off-by: Runji Wang wangrunji0408@163.comI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Building OpenSSL from source is a bottleneck of compilation. This PR disables "vendored" feature of openssl, requires a system openssl3 and statically links it on release.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
Signed-off-by: Runji Wang